On Wed, 12 Apr 2017 04:15:28 +0300 "Dmitry V. Levin" <l...@altlinux.org> wrote:
> On Mon, Apr 10, 2017 at 01:45:01PM +0300, Edgar Kaziahmedov wrote:
> > * v4l2.c (print_v4l2_format_fmt): Add decoding for the remaining
> > V4L2_BUF_TYPEs, add 'struct tcb' arg as print_array using.
> > (print_v4l2_clip): New function to print the clips field in case
> > of the overlay type buf
> > (print_v4l2_format): Add processing of the returned value of
> > the print_v4l2_format_fmt.
>
> * v4l2.c: Include "xlat/v4l2_vbi_flags.h" and
> "xlat/v4l2_sliced_flags.h". (struct_v4l2_clip): New typedef.
> Mpersify it. (print_v4l2_clip): New function.
> (print_v4l2_format_fmt): Use it. Add struct tcb argument. Implement
> decoding of the remaining V4L2_BUF_TYPE_* types.
One more question. What do you mean writing "Use it"?
>
> The last sentence would be a better alternative for the subject of
> this commit.
>
> > * xlat/v4l2_vbi_flags.in: Add V4L2_VBI_UNSYNC, V4L2_VBI_INTERLACED
> > introduced by linux kernel commit v2.6.12-rc2^0.
>
> grammar: add something and something else.
>
> In fact, they were defined in the first commit that introduced v4l2
> in the kernel, i.e. v2.5.46~39^2~23^2~4.
>
> > Add V4L2_VBI_ITU_525_F1_START, V4L2_VBI_ITU_525_F2_START,
> > V4L2_VBI_ITU_625_F1_START, V4L2_VBI_ITU_625_F2_START introduced by
> > linux kernel commit v3.17-rc1~112^2~217.
>
> grammar: add one, two, and three (note the comma before "and").
>
> > * xlat/v4l2_sliced_flags.in: Add V4L2_SLICED_TELETEXT_B,
> > V4L2_SLICED_VPS, V4L2_SLICED_CAPTION_525, V4L2_SLICED_WSS_625,
> > V4L2_SLICED_VBI_525, V4L2_SLICED_VBI_625 introduced by linux kernel
> > commit v2.6.14-rc2~64.
>
> Likewise.
>
> Actually, there is no need to list them all, the tradition of adding
> new files is simple:
>
> * xlat/v4l2_sliced_flags.in: New file.
> * xlat/v4l2_vbi_flags.in: Likewise.
>
> > * configure.ac: Check for availabilty of V4L2_BUF_TYPE_SDR_CAPTURE
> > and V4L2_BUF_TYPE_SDR_OUTPUT constants.
>
> * configure.ac (AC_CHECK_DECLS): Add V4L2_BUF_TYPE_SDR_CAPTURE
> and V4L2_BUF_TYPE_SDR_OUTPUT.
>
> [...]
> > + /* VIDEO_OVERLAY is earlier than Linux-2.6.12-rc2 */
> > + case V4L2_BUF_TYPE_VIDEO_OVERLAY: {
>
> It was defined in the first commit that introduced v4l2 in the kernel.
>
> [...]
> > + /* both are earlier than Linux-2.6.12-rc2 */
> > case V4L2_BUF_TYPE_VBI_CAPTURE:
> > case V4L2_BUF_TYPE_VBI_OUTPUT:
>
> Likewise.
>
>
pgpPSAsCb3c5j.pgp
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
