[ 
http://www.stripesframework.org/jira/browse/STS-592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11470#action_11470
 ] 

Andrew Jaquith commented on STS-592:
------------------------------------

Ben -- thanks for the patch for MockRoundrip. Also, I'll file an enhancement 
request for UrlBindingFactory.

One last stab at the "clean URLs" issue:

I agree that supporting query string characters in clean URLs might be 
difficult. But, what about a rule of thumb that says, "if we detect a '?' in 
the matching URL binding string, the developer clearly intended for it to be 
part of the binding, and thus we ignore (i.e., don't merge) the 
container-parsed parameters"?

> Stripes 1.5 URLBindingFactory does not parse clean URLs with appended 
> parameters 
> ---------------------------------------------------------------------------------
>
>                 Key: STS-592
>                 URL: http://www.stripesframework.org/jira/browse/STS-592
>             Project: Stripes
>          Issue Type: Bug
>          Components: ActionBean Dispatching
>    Affects Versions: Release 1.5
>         Environment: OS X
>            Reporter: Andrew Jaquith
>            Assignee: Ben Gunter
>            Priority: Minor
>             Fix For: Release 1.5.1
>
>         Attachments: MockRoundtrip_query_string_support.patch
>
>
> I've found an issue in build 947 with the implementation of clean URLs, which 
> relates to differences in how the ActionResolver and UrlBuilder handle 
> appended parameters. I had previously written up my observations in comments 
> on STS-262, but that issue had been marked closed. I was not sure if my 
> comments had been read, hence I am opening a new issue. 
> Summary:
> With a given "clean" @UrlPattern, if parameters otherwise unspecified in the 
> pattern are added to the UrlBuilder, they are properly appended in the 
> generated URL. But if that generated URL is passed back to the StripesFilter, 
> the trailing parameters are not parsed as expected, even if the ActionBean 
> has properties that those parameters "should" bind do. In other words, it is 
> not a "round trip" operation. 
> For more in-depth comments, *and* a proposed patch to fix the issue, see 
> STS-262. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://www.stripesframework.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development

Reply via email to