Some unit tests depend on the system locale
-------------------------------------------

                 Key: STS-768
                 URL: http://www.stripesframework.org/jira/browse/STS-768
             Project: Stripes
          Issue Type: Improvement
          Components: ActionBean Dispatching
    Affects Versions: Release 1.5.3, Release 1.5.2, Release 1.5.1, Release 1.5
         Environment: Windows 7, german installation (affects many non-english 
operating sytems with different locale behaviour)
            Reporter: Marcus Kraßmann
            Priority: Trivial
         Attachments: test_locale_fixes.patch

Some unit tests depend on an english system locale. There, doubles are written 
as "1.23", but in other countries the corresponding notation differs - german 
system use "1,23" for the same meaning. The consequence: Some unit tests don't 
run on non-english systems.

I fixed this behaviour for the tests that failed on my system by adding the 
english locale to the roundtrip requests. This change alone did not fix the 
problem, so I had to create a small MockLocalePicker that simply accepts the 
locale from the request. In this combination, all tests run fine on my german 
system.

Attached is a proposed patch based on the 1.5.x branch.

Best regards,
Marcus

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://www.stripesframework.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development

Reply via email to