Well, you can close it I think :)
It's usually better to go through a ticket first, but as the patch was
simple and affecting a few tests only, I incorporated it directly.
Cheers
Remi
2010/9/24 M.C.S. <[email protected]>
> Hmpf, and I just created a JIRA issue with the patch file attached. Looks
> like I was too slow :-D
>
> Am 24.09.2010 08:56, schrieb VANKEISBELCK Remi:
>
> Hi Marcus,
>
> Excellent ! I also have a non english default locale and thereby some tests
> are failing recurrently...
> Now it's all green :)
>
> I've applied it, rev 1272. Thanks !
>
> Cheers
>
> Remi
>
>
> 2010/9/23 M.C.S. <[email protected]>
>
>> Hi,
>>
>> I realized that the tests don't pass for some locales. In my case, the
>> DefaultLocalePicker returns "de_DE" instead of "en" even if I explicitly add
>> "en" to the MockRequest. To solve this and being able to write
>> locale-specific tests, I created a very simple, but working MockLocalePicker
>> and added it to the StripesTestFixture. This way, the unit tests run with
>> the system's default locale, but can be overridden in the test by adding a
>> specific locale. The "broken" tests now are fixed to Locale.ENGLISH so they
>> will run fine.
>>
>> A patch file based on the 1.5.x branch is attached to this email. Feel
>> free to change/criticize it :-)
>>
>> Best regards,
>> Marcus
>>
>>
>> ------------------------------------------------------------------------------
>> Nokia and AT&T present the 2010 Calling All Innovators-North America
>> contest
>> Create new apps & games for the Nokia N8 for consumers in U.S. and Canada
>> $10 million total in prizes - $4M cash, 500 devices, nearly $6M in
>> marketing
>> Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
>> http://p.sf.net/sfu/nokia-dev2dev
>> _______________________________________________
>> Stripes-development mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/stripes-development
>>
>>
>
> ------------------------------------------------------------------------------
> Nokia and AT&T present the 2010 Calling All Innovators-North America contest
> Create new apps & games for the Nokia N8 for consumers in U.S. and Canada
> $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
> Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
> http://p.sf.net/sfu/nokia-dev2dev
>
>
> _______________________________________________
> Stripes-development mailing
> [email protected]https://lists.sourceforge.net/lists/listinfo/stripes-development
>
>
>
>
> ------------------------------------------------------------------------------
> Nokia and AT&T present the 2010 Calling All Innovators-North America
> contest
> Create new apps & games for the Nokia N8 for consumers in U.S. and Canada
> $10 million total in prizes - $4M cash, 500 devices, nearly $6M in
> marketing
> Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
> http://p.sf.net/sfu/nokia-dev2dev
> _______________________________________________
> Stripes-development mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/stripes-development
>
>
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development
