[ 
http://www.stripesframework.org/jira/browse/STS-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12110#comment-12110
 ] 

Nikolaos commented on STS-433:
------------------------------

After some more extensive testing I found 2 issues in the patch that have now 
been corrected and will be uploaded in a new patch (to follow):

1)  I had been doing the injection in doEndTag which resulted in some funky 
results... doStartTag is the correct place

2)  It's a little odd that Stripes considers a HTML Label to be a subclass of 
InputTagSupport however in any event we don't want titles appearing on labels 
so the new code needs to exclude adding title to labels via a simple instanceof 
check.

The details to be included in the next patch STS433_PATCH_VERSION_2.txt however 
to reiterate essentially this allows one to change: 
<fmt:message var="userAddressTitle" key="user.address.title" />
<stripes:text name="user.address" title="${userAddressTitle}"/>

To:
<stripes:text name="user.address"/>

And title attribute with localized text will get rendered IFF it is found in 
the Stripes resource bundle.  Save A LOT of boilerplate JSP coding!!!!!

I'll attach the full patch file as STS433_PATCH_VERSION_2.txt

--Nikolaos

> Localize title attribute for Stripes tags.
> ------------------------------------------
>
>                 Key: STS-433
>                 URL: http://www.stripesframework.org/jira/browse/STS-433
>             Project: Stripes
>          Issue Type: Improvement
>          Components: Tag Library
>    Affects Versions: Release 1.5
>         Environment: Mac OS X 10.4.10, Java 1.5.0_07
>            Reporter: Iwao AVE!
>            Priority: Trivial
>         Attachments: STS-433.patch, STS433_PATCH_VERSION_2.txt
>
>
> It would be nice if Stripes tag localizes its title.
> So that we can write
> <stripes:text name="user.address" title="user.address.title" />
> instead of
> <fmt:message var="userAddressTitle" key="user.address.title" />
> <stripes:text name="user.address" title="${userAddressTitle}"/>

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development

Reply via email to