Freddy,
Starting a post with an evaluation of anyone's contributions to a
mailing list is somewhat over the top and a little condescending. The
JIRA issue sounded like... this behaviour appears odd so I am opening a
bug report based on what I observed. I still think people should be
encouraged to discuss issues on the lists - with some likely back and
forth - unless they are quite confident there is defect. Sebastien's
comments didn't seem to indicate that. Also I think your reading far
more into multiple ? than was stated... they are NOT equivalent to
multiple ! and were meaning to denote being puzzled by the statement of
not being sure and the ensuing bug report. If you want to be picky then
please refrain from twisting things.
As far as the issue is concerned... I meant to say that involves
"multiple requests" not "multiple redirects". In addition, more details
are required than simply rubber stamping it as a bug... such as:
- What are the URLs of the requests to A1 and A2?
- Is the FlashScope key visible as a parameter on the redirect URL?
- Is RedirectResolution being used to perform the redirect or something
else? You may assume that, and indeed it would be problematic, if it
was the case, but it isn't clear in the bug report.
- What happens in getMessage() on the incoming request to A2? Is the
FlashScope that is obtained from the request matching the one passed in
or is a new one created? The method is mentioned but what happens is not.
- Is there a delay anywhere of over 2 minutes? (Not likely but we have
UrlRewriteFilter fronting our Apps and if I slowly debug step through it
and then get to Stripes the FlashScope should have been cleaned up)
- Can a small self-contained reproducible case be created? Or not?
- What version of 1.5.x is failing? Has this ever worked? If so what
version of 1.5.x?
Sebastien: Getting information on the above would help your bug report
IMHO.
All this is easily weeded out in a conversation vs. a bug report.
Without these details the report is possibly "pointless" (I hope you did
read the word "possibly" in my original reply). Personally, I wouldn't
be so quick to judge - and jump to so many conclusions - on so many
accounts - without more details - even if this turns out to be a clear
cut bug.
--Nikolaos
Freddy Daoud wrote:
Nikolaos,
While for the most part I find your contributions to the Stripes MLs
useful, detailed and informative, I think you are being somewhat
harsh here. Also the multiple "????" are not necessary, one is
enough :-)
More importantly, I believe you are incorrect. The situation described
does not involve multiple redirects, only one. A1 adds a message to
the flash scope, redirects to A2, which adds another message and
forwards to a JSP. Like Sebastien, I'd expect to see both messages in
this case.
I agree with you that one should inquire before filing a bug report,
but in this particular case, I think the bug report is justified.
Freddy
On Mon, 21 Feb 2011 13:51 -0500, "Nikolaos Giannopoulos"
<[email protected]> wrote:
Sebastien,
If you say "I don't know enough stripes to tell exactly what happens..."
then why open a possibly "pointless" bug report and not post a question
to Stripes user mailing list???
Personally, I am not surprised that the flashscope does not retain the
messages across multiple redirects. Why should it????
As far as your problem is concerned, a simple work around that should
work would be to at the start of A2 processing simply grab all messages
and add them again on A2... I haven't tried this mind you but I would
guess that is what you want.
--Nikolaos
Sebastien Lorber (JIRA) wrote:
Problem in flash scope and messages
-----------------------------------
Key: STS-812
URL: http://www.stripesframework.org/jira/browse/STS-812
Project: Stripes
Issue Type: Bug
Components: Context Management
Affects Versions: Release 1.5
Environment: Any
Reporter: Sebastien Lorber
There is a problem in the way messages are managed in flash scopes.
Actually, when you add a message M1 on an action A1 and then redirect on the
action A2 that add a message M2, only the M2 message will be displayed on the
end page and M1 is lost.
The M1 message is well displayed when you don't add M2 on A2.
I don't know enough stripes to tell exactly what happens but all i know is that
the previous flashscope is well retrieved and contains M1 message.
The request attribute "_stripes_defaultMessages" is well set with M1 on the
beginning of the GET call but i think it is being overriden with a new collection
containing only M2.
I guess some fix could be to do some rework on
net.sourceforge.stripes.action.ActionBeanContext.getMessages(String)
For exemple to have a system that takes messages from the previous scope and
add them to the current one.
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development
------------------------------------------------------------------------------
Index, Search & Analyze Logs and other IT data in Real-Time with Splunk
Collect, index and harness all the fast moving IT data generated by your
applications, servers and devices whether physical, virtual or in the cloud.
Deliver compliance at lower cost and gain new business insights.
Free Software Download: http://p.sf.net/sfu/splunk-dev2dev
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development
--
Nikolaos Giannopoulos
Director of Information Technology
BrightMinds Software Inc.
e. [email protected]
w. www.brightminds.org
t. 1.613.822.1700
c. 1.613.797.0036
f. 1.613.822.1915
------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development
