Stripersist: incorrect code in getConfigurationSwitch
-----------------------------------------------------
Key: STS-814
URL: http://www.stripesframework.org/jira/browse/STS-814
Project: Stripes
Issue Type: Bug
Reporter: kdeveloper
Priority: Trivial
While debuging I found that this code in
org.stripesstuff.stripersist.Stripersist was incorrect:
private boolean getConfigurationSwitch(String name, boolean defaultValue) {
String stringValue =
configuration.getBootstrapPropertyResolver().getProperty(name);
if (stringValue != null)
return Boolean.valueOf(automaticTransactions); // Wrong! Should be
stringValue
else
return defaultValue;
}
This line of code:
return Boolean.valueOf(automaticTransactions)
Should become:
return Boolean.valueOf(stringValue)
This is a minor bug, as the getConfigurationSwitch is currently not been used
for anything else than the automaticTransactions switch. The two other
configuration switches 'dontRollbackTransactions' and 'dontCloseEntityManager'
seem obsolete and unused.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development
