[ 
http://www.stripesframework.org/jira/browse/STS-798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ben Gunter resolved STS-798.
----------------------------

       Resolution: Fixed
    Fix Version/s: Release 1.5.6
         Assignee: Ben Gunter

I had to do the reverse of what you suggested: I fixed the documentation to 
match the code. There is a unit test that expects the ParseException for a 
zero-length pattern. I did remove the redundant null and length checks, though.

> UrlBindingFactory.parseUrlBinding() code does not match documentation
> ---------------------------------------------------------------------
>
>                 Key: STS-798
>                 URL: http://www.stripesframework.org/jira/browse/STS-798
>             Project: Stripes
>          Issue Type: Bug
>    Affects Versions: Release 1.5.5
>            Reporter: Ville Skyttä
>            Assignee: Ben Gunter
>            Priority: Minor
>             Fix For: Release 1.5.6
>
>         Attachments: ubf.patch
>
>
> The code in UrlBindingFactory.parseUrlBinding() does not match its 
> documentation, docs say null will be returned for zero-length patterns, but 
> the code throws a ParseException for them. The attached patch against current 
> svn trunk changes the implementation to match the docs. I haven't run into 
> any actual issues with this (or tested the patch), it's just something I 
> happened to notice while looking for something else.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development

Reply via email to