[
http://www.stripesframework.org/jira/browse/STS-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12369#comment-12369
]
Yannik Hampe commented on STS-841:
----------------------------------
Note that this will work without a List as well.
If "myProperty" is declared like this:
@ValidateNestedProperties({
@Validate(field="i", minvalue=1)
})
public MyClass myProperty;
Then one can bypass the validation as well, for example using the following
URL: Demo.action?myProperty[i]=-5
> Validation sometimes fails with indexed property notation
> ---------------------------------------------------------
>
> Key: STS-841
> URL: http://www.stripesframework.org/jira/browse/STS-841
> Project: Stripes
> Issue Type: Bug
> Components: Validation
> Affects Versions: Release 1.5.6
> Reporter: Ben Gunter
> Fix For: Release 1.5.7
>
>
> This is the problem as it was described to me by Yannik Hampe.
> =====
> Consider the following action bean:
> --snip
> public class DemoAction implements ActionBean
> {
> private ActionBeanContext context;
> @ValidateNestedProperties({
> @Validate(field="i", minvalue=1)
> })
> public List<MyClass> myProperty;
> public Resolution demo() throws Exception
> {
> return new StreamingResolution("text/plain",
> Integer.toString(myProperty.get(0).i));
> }
>
> public static class MyClass
> {
> public Integer i;
> }
> @Override
> public void setContext(ActionBeanContext context)
> {
> this.context = context;
> }
> @Override
> public ActionBeanContext getContext()
> {
> return context;
> }
> }
> --snip
> There are two ways to call this actionBean and pass a value i:
> 1. Demo.action?myProperty[0].i=-5
> 2. Demo.action?myProperty[0][i]=-5
> Using the first method will be caught by Stripes' validation system. Using
> the second URL will print "-5" in the Browser, proving that the @Validate
> annotation has been bypassed.
> This happens, because in net.sourceforge.stripes.controller.ParameterName the
> "strippedName" is generated by using the matcher Pattern.compile("\\[.*?\\]")
> to remove indexes on indexed properties. But this will also remove the [i] in
> the example above, causing Stripes to use the @Validate tag that is attached
> to myProperty instead of the corresponding @Validate tag in the
> @ValidateNestedProperties annotation. Since in the example above the former
> tag is not present, Stripes will not perform any validation at all, but
> binding still works.
> In the example above the consequences don't matter. But in other situations
> the validation tags may be used to protect the system from malicious input,
> for example if someone uses mask="^[a-z]$" and expects the string then to be
> safe to be used in certain parsers, such as SQL-parsers without further
> escaping.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
uberSVN's rich system and user administration capabilities and model
configuration take the hassle out of deploying and managing Subversion and
the tools developers use with it. Learn more about uberSVN and get a free
download at: http://p.sf.net/sfu/wandisco-dev2dev
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development
