[
http://www.stripesframework.org/jira/browse/STS-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871#comment-12871
]
Remi VANKEISBELCK commented on STS-822:
---------------------------------------
Just had a look.
I think the best option is to change the keyword. For the sake of simplicity
I'll call it 'self', but we can choose another name.
We keep backward compat : when 'this' is used in some EL validation expression,
we evaluate anyway, but log a WARNing message telling the user that (s)he uses
a deprecated keyword and should change ASAP to 'self'.
If someone uses 'this' with an EL engine that doesn't support it and
workarounds the bug by configuring the server (as decribed for tomcat in this
ticket), (s)he'll get the warning message telling her(him) to update the EL
expressions.
Note that 'this' is a shortcut to the property name. All ExpressionEvaluators
will try to lookup the property on the ationbean if it ain't 'this'. So I guess
configurability of the keyword ain't really useful. A meaningful name is enough
IMO.
The only thing is to avoid another potential keyword, or worse : a clash with a
user-defined property name : EL would evaluate the other property instead of
'this' !
'self' looks pretty good to me. It ain't used much in Java. 'that' is a bit too
much JavaScript and one might have coded a 'getThat()' method...
I ain't fond of underscores ("_this") but I could live with it as well.
Tell me what you think.
> bugzooky fails on account creation
> ----------------------------------
>
> Key: STS-822
> URL: http://www.stripesframework.org/jira/browse/STS-822
> Project: Stripes
> Issue Type: Bug
> Components: Examples
> Affects Versions: Release 1.5.6
> Environment: windows xp, tomcat 7.0.12
> Reporter: Rusty Wright
> Assignee: Remi VANKEISBELCK
> Fix For: Release 1.5.8, Release 1.6
>
> Attachments: exception report.txt, ExceptionTomcat7.txt
>
>
> Bombed on the user register page when I clicked Create Account. See attached
> backtrace.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development
