Hi Remi,

The static StripesFilter.getConfiguration() makes access to the current
runtime configuration very convenient (and it is heavily used within
many Stripes internal classes). On the other hand, statics in general
make unit testing a mess. And Stripes already offers Dependency
Injection with the ConfigurableComponent interface for custom Stripes
components.

You wrote about a simpler mechanism. I'm curious what you are thinking
about.

Kind regards,
Marcus


Am 17.02.2013 21:53, schrieb Remi VANKEISBELCK:
> It's done, I have refactored the unit tests so that they use a 
> MockServletContext whenever they need to access the configuration. 
>
> The current test base was relying on ugly statics, it ain't the case now, we 
> create and stop the StripesFilter (via MockServletContext) when a utest needs 
> to access the configuration. 
>
> This StripesFilter.getConfiguration() thing is pretty abscure to me, so again 
> please tell me why it's done like this if you have any idea... I'd quite like 
> to remove all this for a simpler mechanism...
>
> Cheers
>
> Remi
> ------------------------------------------------------------------------------
> The Go Parallel Website, sponsored by Intel - in partnership with Geeknet, 
> is your hub for all things parallel software development, from weekly thought 
> leadership blogs to news, videos, case studies, tutorials, tech docs, 
> whitepapers, evaluation guides, and opinion stories. Check out the most 
> recent posts - join the conversation now. http://goparallel.sourceforge.net/
> _______________________________________________
> Stripes-development mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/stripes-development


------------------------------------------------------------------------------
The Go Parallel Website, sponsored by Intel - in partnership with Geeknet, 
is your hub for all things parallel software development, from weekly thought 
leadership blogs to news, videos, case studies, tutorials, tech docs, 
whitepapers, evaluation guides, and opinion stories. Check out the most 
recent posts - join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development

Reply via email to