Hi,

WinCVS (www.cvsgui.org) supports CVS trough a
web-proxy.

Regards,
Slawek

--- [EMAIL PROTECTED] wrote:
> PropertyMessageResource uses a HashMap as a Set. 
> Instead, an actual Set
> should be used.  As well, variables are declared of
> type HashMap rather
> than being Map and only instantiating a HashMap. 
> This is poor programming
> practice becuase it can cause problems with future
> fixes and I've also
> fixed that.
> 
> Sorry for not providing a diff, I don't have a copy
> of the original version
> handy, nor do I have a CVS shaped hole in the
> firewall here to allow me to
> use CVS.
> 
> /*
>  * $Header:
>
/home/cvspublic/jakarta-struts/src/share/org/apache/struts/util/PropertyMessageResources.java,v
> 
> 1.3 2001/02/12 00:32:14 craigmcc Exp $
>  * $Revision: 1.3 $
>  * $Date: 2001/02/12 00:32:14 $
>  *
>  *
>
====================================================================
>  *
>  * The Apache Software License, Version 1.1
>  *
>  * Copyright (c) 1999-2001 The Apache Software
> Foundation.  All rights
>  * reserved.
>  *
>  * Redistribution and use in source and binary
> forms, with or without
>  * modification, are permitted provided that the
> following conditions
>  * are met:
>  *
>  * 1. Redistributions of source code must retain the
> above copyright
>  *    notice, this list of conditions and the
> following disclaimer.
>  *
>  * 2. Redistributions in binary form must reproduce
> the above copyright
>  *    notice, this list of conditions and the
> following disclaimer in
>  *    the documentation and/or other materials
> provided with the
>  *    distribution.
>  *
>  * 3. The end-user documentation included with the
> redistribution, if
>  *    any, must include the following
> acknowlegement:
>  *       "This product includes software developed
> by the
>  *        Apache Software Foundation
> (http://www.apache.org/)."
>  *    Alternately, this acknowlegement may appear in
> the software itself,
>  *    if and wherever such third-party
> acknowlegements normally appear.
>  *
>  * 4. The names "The Jakarta Project", "Struts", and
> "Apache Software
>  *    Foundation" must not be used to endorse or
> promote products derived
>  *    from this software without prior written
> permission. For written
>  *    permission, please contact [EMAIL PROTECTED]
>  *
>  * 5. Products derived from this software may not be
> called "Apache"
>  *    nor may "Apache" appear in their names without
> prior written
>  *    permission of the Apache Group.
>  *
>  * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY
> EXPRESSED OR IMPLIED
>  * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> IMPLIED WARRANTIES
>  * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
> PURPOSE ARE
>  * DISCLAIMED.  IN NO EVENT SHALL THE APACHE
> SOFTWARE FOUNDATION OR
>  * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT,
> INDIRECT, INCIDENTAL,
>  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
> (INCLUDING, BUT NOT
>  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
> SERVICES; LOSS OF
>  * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> HOWEVER CAUSED AND
>  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
> STRICT LIABILITY,
>  * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> ARISING IN ANY WAY OUT
>  * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
> THE POSSIBILITY OF
>  * SUCH DAMAGE.
>  *
>
====================================================================
>  *
>  * This software consists of voluntary contributions
> made by many
>  * individuals on behalf of the Apache Software
> Foundation.  For more
>  * information on the Apache Software Foundation,
> please see
>  * <http://www.apache.org/>.
>  *
>  */
> 
> 
> package org.apache.struts.util;
> 
> 
> import java.io.InputStream;
> import java.util.Enumeration;
> import java.util.HashMap;
> import java.util.Locale;
> import java.util.Properties;
> 
> 
> /**
>  * Concrete subclass of
> <code>MessageResources</code> that reads message
> keys
>  * and corresponding strings from named property
> resources in the same
> manner
>  * that
> <code>java.util.PropertyResourceBundle</code> does. 
> The
>  * <code>base</code> property defines the base
> property resource name, and
>  * must be specified.
>  * <p>
>  * <strong>IMPLEMENTATION NOTE</strong> - This class
> trades memory for
>  * speed by caching all messages located via
> generalizing the Locale under
>  * the original locale as well.
>  * This results in specific messages being stored in
> the message cache
>  * more than once, but improves response time on
> subsequent requests for
>  * the same locale + key combination.
>  *
>  * @author Craig R. McClanahan
>  * @version $Revision: 1.3 $ $Date: 2001/02/12
> 00:32:14 $
>  */
> 
> public class PropertyMessageResources extends
> MessageResources {
> 
> 
>     //
>
-----------------------------------------------------------
> Constructors
> 
> 
>     /**
>      * Construct a new PropertyMessageResources
> according to the
>      * specified parameters.
>      *
>      * @param factory The MessageResourcesFactory
> that created us
>      * @param config The configuration parameter for
> this MessageResources
>      */
>     public
> PropertyMessageResources(MessageResourcesFactory
> factory,
>                                     String config) {
> 
>         super(factory, config);
> 
>     }
> 
> 
>     /**
>      * Construct a new PropertyMessageResources
> according to the
>      * specified parameters.
>      *
>      * @param factory The MessageResourcesFactory
> that created us
>      * @param config The configuration parameter for
> this MessageResources
>      * @param returnNull The returnNull property we
> should initialize with
>      */
>     public
> PropertyMessageResources(MessageResourcesFactory
> factory,
>                                     String config,
> boolean 
=== message truncated ===


=====
Best Regards,
Slawek

__________________________________________________
Do You Yahoo!?
Great stuff seeking new owners in Yahoo! Auctions! 
http://auctions.yahoo.com

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to