Well, I don't think need to do anything fancy, given the static nature of most of the references. I think we should just make all '8080' to '9090' and be done with it. That will fix the testing process and fill the need of the original commit.
Sorry I can't give you a diff -u, I can provide files and line numbers if it helps. -- James Mitchell ----- Original Message ----- From: "Robert Leland" <[EMAIL PROTECTED]> To: "Struts Developers List" <[EMAIL PROTECTED]> Sent: Friday, February 07, 2003 4:30 PM Subject: Re: Cactus Test Failures? > So basically you want to get those values from a property file? > I'll see if I can replicate your changes since I don't have a diff. > > -Rob > > James Mitchell wrote: > > Ok, couple of things: > > > > After careful digging I think I've discovered the problem(s). > > > > 1. getServerPort in MockHttpServletRequest is hard-coded to always return > > 8080. > > > > 2. cactus.properties has: > > cactus.contextURL = http://localhost:8080/test > > > > 3. TestRequestUtils has a couple of places that specify port 8080, > > > > * Note - because of the hard-coded port I had to change server.xml under > > both tomcat32 and tomcat33 > > > > After changing all those references, the tests ran without a hitch (see > > attached). > > So I guess I won't need to patch my test after all. Thank God!! I would > > hate to have to buy 5,000 struts-users a beer ;) > > > > Craig, can you (or someone) take care of these commits (I am not able to > > right now for reasons previously stated). > > > > Hope that nails it!! > > > > -- > > James Mitchell > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
