DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27051>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27051

PresentTag.java swallows JSPException when it should be thrown

           Summary: PresentTag.java swallows JSPException when it should be
                    thrown
           Product: Struts
           Version: 1.1 RC1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Custom Tags
        AssignedTo: [EMAIL PROTECTED]
        ReportedBy: [EMAIL PROTECTED]


In the PresentTag.java class there is a block of code starting at line 137 
that attempts to look up the value of a property that was specified on a 
<logic:present> tag. When the property name is incorrect the tag functions 
normally and reports that the value is present.  When the property attribute 
value is incorrect the PresentTag class should allow the JSPException that is 
thrown by the RequestUtils.lookup() method to be propagated since this 
indicates a programmer error and the JSP page on which the tag is located 
should not continue processing.

Code Fragment from PresentTag.java
-----------------------------------------
Object value = null;
try {
                if (property != null) {
                    value = RequestUtils.lookup(pageContext, name,
                                                property, scope);
                } else {
                    value = RequestUtils.lookup(pageContext, name, scope);
                }
            } catch (JspException e) {
                value = null;   <-- THE EXCEPTION IS BEING SWALLOWED AND 
SHOULD BE RE-THROWN INSTEAD.
            }

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to