Once a release is tagged that's it. We could retag and do 1.2.1, however there will probably be other things that need to be fixed. The point is to get 1.2.0 out the door and then see about making whatever fixes that need to happen.
Do we have or want to make a 1.2 branch ? > -----Original Message----- > From: Joe Germuska [mailto:[EMAIL PROTECTED] > Sent: Tuesday, February 24, 2004 02:03 PM > To: 'Struts Developers List' > Subject: Re: Bug in JavascriptValidatorTag > > Hm. No one brought that up when we were talking about implementing > the fix, but that explains the old default behavior, which was to > render the javascript without wrapping script tags. That makes sense > when you're rending javascript for external use. > > It seems to me that the solution would be fixed by moving the check > for a non-null form into createDynamicJavascript, where there is > nothing to be done if the form is null. > > Does this get fixed in 1.2.1? Or do we fix it now and move the > release tag for that file? > > Obviously I don't use static javascript, or I would have seen the > problem with the fix before -- would anyone care to double check my > logic here? > > Joe > > > At 6:29 AM +0100 2/24/04, Ralph Schaer wrote: > >I've found a bug in JavascriptValidatorTag.java. > >(Nightly build 2004/02/23) > > > >I use this tag in one of my jsp pages: > ><html:javascript dynamicJavascript="false" staticJavascript="true"/> > > > >Now the JavascriptValidatorTag crashes with this error message: > >javax.servlet.jsp.JspException: No form found under name null, locale de_CH > > > >The error occurs on line 381. There is a null check for the form > >attribute. But there is no need for a form when you just want the > >static part of the validator javascript code. > > > > if (form == null) > > { > > throw new JspException("No form found under name " > > + formName > > + ", locale " > > + locale); > > } > > > -- > Joe Germuska > [EMAIL PROTECTED] > http://blog.germuska.com > "Imagine if every Thursday your shoes exploded if you tied them > the usual way. This happens to us all the time with computers, and > nobody thinks of complaining." > -- Jef Raskin > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
