Martin,
Thanks for applying my patch. I haven't tested it yet, but I had one issue
to bring up regarding the patch you applied. You did not apply my patch as
I had implemented it exactly. One of the things I did was to refactor
slightly so that getting the action mappings was pulled into a separate
method, as well as the findMapping method since both of these were done in
other parts of the code as well. While what you applied appears fine
functionality-wise, I do think that refactoring and cleaning up some code at
the same time is a worthy goal.
Is there a reason my patch wasn't applied as-is?
Thanks,
Erik
----- Original Message -----
From: <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Sunday, September 16, 2001 10:02 PM
Subject: Re: [PATCH] FormTag - call reset after instantiation
> I just checked in this change. Please let me know if you see any problems.
>
> --
> Martin Cooper
>
>
> ----- Original Message -----
> From: "Erik Hatcher" <[EMAIL PROTECTED]>
> To: <[EMAIL PROTECTED]>
> Sent: Saturday, September 08, 2001 8:44 PM
> Subject: Re: [PATCH] FormTag - call reset after instantiation
>
>
> > Followup: I just checked Bugzilla at:
> > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=2108
> >
> > It says its been applied and the issue closed, but I don't see it CVS.
> It
> > seems that the patch slipped through the cracks somehow.
> >
> > Could a committer look into this?
> >
> > Thanks again,
> > Erik
> >
> >
> > ----- Original Message -----
> > From: "Erik Hatcher" <[EMAIL PROTECTED]>
> > To: <[EMAIL PROTECTED]>
> > Sent: Saturday, September 08, 2001 8:38 PM
> > Subject: [PATCH] FormTag - call reset after instantiation
> >
> >
> > > I'd like to lobby for this previously submitted patch to be applied:
> > >
http://www.mail-archive.com/struts-dev@jakarta.apache.org/msg02556.html
> > >
> > > Thanks,
> > > Erik
> > >
> > >
> > >
> >
>
>
>
