I'm thinking that we've been saying the tags are HTML 4.01 compliant,
and then using that as a rationale for not including some proprietary
attributes. So if we've missed any of the attributes in the W3C spec,
then I'd say that would be a bug (breaks our contract).
But, if we did something like add a "literal" attribute to spit out
proprietary attributes (e.g. literal="wrap=virtual" for textarea), I'd
call that a feature.
-- Ted Husted, Husted dot Com, Fairport NY USA.
-- Custom Software ~ Technical Services.
-- Tel +1 716 737-3463
-- http://www.husted.com/about/struts/
[EMAIL PROTECTED] wrote:
>
> I have no problem with applying this to 1.0.1 if you think that's the right
> thing to do. To be honest, I wasn't sure whether to treat this (and similar
> "missing attribute" reports) as a bug or a feature request. :-}
>
> --
> Martin Cooper
>
> ----- Original Message -----
> From: "Ted Husted" <[EMAIL PROTECTED]>
> To: <[EMAIL PROTECTED]>
> Sent: Sunday, September 23, 2001 7:43 AM
> Subject: Re: cvs commit:
> jakarta-struts/src/share/org/apache/struts/taglib/html ImageTag.java
>
> > Should we apply this to 1.0.1 too? Was it a bug (or oversight)?
> >
> > [EMAIL PROTECTED] wrote:
> > >
> > > martinc 01/09/17 22:50:51
> > >
> > > Modified: doc struts-html.xml
> > > src/share/org/apache/struts/taglib/html ImageTag.java
> > > Log:
> > > Add the 'align' attribute to the <html:image> tag.
> > > PR: 3288
> > > Submitted by: Misak Boulatian
> > >
> > > Revision Changes Path
> > > 1.22 +9 -0 jakarta-struts/doc/struts-html.xml
> > >
> > > Index: struts-html.xml
> > > ===================================================================
> > > RCS file: /home/cvs/jakarta-struts/doc/struts-html.xml,v
> > > retrieving revision 1.21
> > > retrieving revision 1.22
> > > diff -u -r1.21 -r1.22
> > > --- struts-html.xml 2001/09/15 05:32:02 1.21
> > > +++ struts-html.xml 2001/09/18 05:50:51 1.22
> > > @@ -1464,6 +1464,15 @@
> > > </attribute>
> > >
> > > <attribute>
> > > + <name>align</name>
> > > + <required>false</required>
> > > + <rtexprvalue>true</rtexprvalue>
> > > + <info>
> > > + <p>The alignment option for this image.</p>
> > > + </info>
> > > + </attribute>
> > > +
> > > + <attribute>
> > > <name>alt</name>
> > > <required>false</required>
> > > <rtexprvalue>true</rtexprvalue>
> > >
> > >
> > >
> > > 1.11 +23 -4 jakarta-struts/src/share/org/apache/struts/taglib
> /html/ImageTag.java
> > >
> > > Index: ImageTag.java
> > > ===================================================================
> > > RCS file:
> /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/ImageTag.ja
> va,v
> > > retrieving revision 1.10
> > > retrieving revision 1.11
> > > diff -u -r1.10 -r1.11
> > > --- ImageTag.java 2001/09/17 19:59:30 1.10
> > > +++ ImageTag.java 2001/09/18 05:50:51 1.11
> > > @@ -1,7 +1,7 @@
> > > /*
> > > - * $Header:
> /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/ImageTag.ja
> va,v 1.10 2001/09/17 19:59:30 husted Exp $
> > > - * $Revision: 1.10 $
> > > - * $Date: 2001/09/17 19:59:30 $
> > > + * $Header:
> /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/ImageTag.ja
> va,v 1.11 2001/09/18 05:50:51 martinc Exp $
> > > + * $Revision: 1.11 $
> > > + * $Date: 2001/09/18 05:50:51 $
> > > *
> > > *
> ====================================================================
> > > *
> > > @@ -81,7 +81,7 @@
> > > * Tag for input fields of type "image".
> > > *
> > > * @author Oleg V Alexeev
> > > - * @version $Revision: 1.10 $ $Date: 2001/09/17 19:59:30 $
> > > + * @version $Revision: 1.11 $ $Date: 2001/09/18 05:50:51 $
> > > */
> > >
> > > public class ImageTag extends SubmitTag {
> > > @@ -98,7 +98,21 @@
> > >
> > > // -------------------------------------------------------------
> Properties
> > >
> > > +
> > > + /**
> > > + * The alignment for this image.
> > > + */
> > > + protected String align = null;
> > >
> > > + public String getAlign() {
> > > + return (this.align);
> > > + }
> > > +
> > > + public void setAlign(String align) {
> > > + this.align = align;
> > > + }
> > > +
> > > +
> > > /**
> > > * The alternate text for this image.
> > > */
> > > @@ -284,6 +298,11 @@
> > > if (tmp != null) {
> > > results.append(" alt=\"");
> > > results.append(tmp);
> > > + results.append("\"");
> > > + }
> > > + if (align != null) {
> > > + results.append(" align=\"");
> > > + results.append(align);
> > > results.append("\"");
> > > }
> > > if (border != null) {
> > >
> > >
> > >
