DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16401>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16401 ActionValidatorUtil ------- Additional Comments From [EMAIL PROTECTED] 2003-09-11 03:34 ------- This seems like it would be pretty useful. A few things: 1. Why do you catch ValidatorException and create a new Exception with its message? 2. As much code as possible should use ActionMessages instead of ActionErrors. ActionErrors is only still around because it's part of ActionForm.validate()'s API. 3. request.getSession().getServletContext() is a Servlet 2.3 feature so we need a different way of getting the ServletContext(). 4. Maybe these methods should go into Action instead of a util class. Action knows about its Servlet which can get you to the ServletContext. 5. If we do go with a util class it should be a Singleton with non-static methods. Statics don't allow for subclassing and specialization which someone will need (we learned this the hard way). --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
