Why not just extend the RequestProcessor with your own (fixed) implementation. Makes more sense then recompiling the source. We do this all the time for authentication filters etc. -Tim
-----Original Message----- From: Adam Hardy [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 09, 2003 4:34 PM To: Struts Users Mailing List Subject: Re: Cancel button not working? I think the only way you will solve this is by downloading the source and putting some logging statnements in there. It's easy enough to use the struts source by putting the org/apache/struts/action/RequestProcessor.java in your own source directory and recompiling and deploying. I don't think you need the whole lot. Here's my base action class for what its worth Adam Sashi Ravipati wrote: > I check the first thing u asked and it is same > i.e > org.apache.struts.taglib.html.Constants.CANCEL_PROPERTY == > org.apache.struts.taglib.html.CANCEL > > and regarding the processPopulate(), I am not sure how I can do this. > > I just downloaded the Struts 1.1 final again and tested but the result > is the same. > > Could u send me the Code u have in your action class. I will try to see > if I missed some thing. > > Thanks > > > >>>>[EMAIL PROTECTED] 07/09/03 11:54AM >>> > > Via logging is basically how I solved it - by figuring out where in > struts I was going wrong. > > What it means now is that RequestProcessor is not setting that attribute > > - you don't need to set it by hand, struts should. > > It's just one little if clause. According to your logging, > request.getParameter("org.apache.struts.taglib.html.CANCEL") has a > value, right? The parameter is not null? > > If the parameter is not null but the attribute is null, that means that > you have either not got the same struts code as me (1.1 final) or your > RequestProcessor is not executing the processPopulate() method. > > I would check 2 things: > > that org.apache.struts.taglib.html.Constants.CANCEL_PROPERTY == > "org.apache.struts.taglib.html.CANCEL" (i.e. that the parameter name / > cancel button name in your HTML is correct) > > and that RequestProcessor.processPopulate() is executing. This method > also puts the data into the action form, so you could use that as a > check unless you can grab the source code and put some logging in there. > > As you can tell I'm intrigued. > Adam > > Sashi Ravipati wrote: > >>request.getAttribute(Globals.CANCEL_KEY) is returning null, so can I > > set > >>it to not null and where Should I do this.. >> >>Can u explain how u solved ur problem.. >> >>Thanks >> >> >> >>>>>[EMAIL PROTECTED] 07/09/03 11:22AM >>> >> >>I've solved my problem. Now you've checked the parameter, check to see > > >>if the request.attribute is set with >>request.getAttribute(Globals.CANCEL_KEY); >> >>For some reason in the RequestProcessor it sets this attribute to true > > >>when the request.parameter is present. Check it out. This is the one >>that the Action.isCancelled() checks. It has to be not null. >> >> >>Adam >> >>Sashi Ravipati wrote: >> >> >>>it says - Cancel >>> >>>I don't know what I am missing which is making this tag not work.. >>> >>>Thanks >>> >>> >>> >>> >>> >>> >>>>>>[EMAIL PROTECTED] 07/09/03 09:50AM >>> >>> >>>Try logging what is in this cancel parameter >>>(org.apache.struts.taglib.html.CANCEL) in the same place where you are >> >> >>>calling isCancelled() >>> >>>Actually I've just realised I'm suffering the same problem. I'll try >> >>it >> >> >>>myself. Let me know what you find as well! >>> >>>Adam >>> >>>Sashi Ravipati wrote: >>> >>> >>> >>>>HTML is as shown below >>>> >>>><input type="submit" name="org.apache.struts.taglib.html.CANCEL" >>>>value="Cancel" onclick="bCancel=true;"> >>>> >>>>>>>[EMAIL PROTECTED] 07/09/03 09:21AM >>> >>>> >>>>Sashi, what HTML does the tag produce? >>>> >>>>Adam >>>> >>>>Sashi Ravipati wrote: >>>> >>>> >>>> >>>> >>>>>I am trying this on Struts 1.1 final. Will this make any > > difference.. > >>>>> >>>>> >>>>> >>>>> >>>>> >>>>>>>>[EMAIL PROTECTED] 07/08/03 05:11PM >>> >>>>> >>>>>Odd, I can't reproduce that in 1.1-rc1. Unless you're >>>>>extending something which might override the >>>>>isCancelled(HttpServletRequest) method, or the >>>>>html:cancel tag is not contained within an html:form >>>>>tag, I can't think of anything else. >>>>> >>>>>m >>>>> >>>>>--- Sashi Ravipati <[EMAIL PROTECTED]> wrote: >>>>> >>>>> >>>>> >>>>> >>>>> >>>>>>This is how I have my cancel tag. >>>>>> >>>>>><html:cancel> >>>>>> <bean:message key="button.cancel"/> >>>>>></html:cancel> >>>>>> >>>>>>>>>[EMAIL PROTECTED] 07/08/03 02:27PM >>> >>>>>> >>>>>>The complete content of your html:cancel tag is >>>>>>probably key to solving this problem. >>>>>> >>>>>>m >>>>>> >>>>>>--- Sashi Ravipati <[EMAIL PROTECTED]> wrote: >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>>>isCancelled(request) is always returning false >>>>>>>(Even when cancel button >>>>>>>is clicked) >>>>>>> >>>>>>>Need some help... >>>>>>> >>>>>>>Thanks >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>>>>>[EMAIL PROTECTED] 07/08/03 09:10AM >>> >>>>>>> >>>>>>>I have a <html:cancel> in my jsp page. and in my >>>>>>>action I have >>>>>>> >>>>>>>if(isCancelled(request)){ >>>>>>> return mapping.findForward("index"); >>>>>>>} >>>>>>> >>>>>>> >>>>>>>But it is not working. What am I doing wrong here. >>>>>> >>>>>>I >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>>>am using Struts 1.1 >>>>>>>final >>>>>>> >>>>>>>Thanks >>>>>>> >>>>>> >>>>>> >>>>>>__________________________________ >>>>>>Do you Yahoo!? >>>>>>SBC Yahoo! DSL - Now only $29.95 per month! >>>>>>http://sbc.yahoo.com >>>>>> >>>>>> >>>>> >>>>>--------------------------------------------------------------------- >>>>> >>>>> >>>>> >>>>> >>>>> >>>>>>To unsubscribe, e-mail: >>>>>>[EMAIL PROTECTED] >>>>>>For additional commands, e-mail: >>>>>>[EMAIL PROTECTED] >>>>>> >>>>> >>>>> >>>>> >>>>>__________________________________ >>>>>Do you Yahoo!? >>>>>SBC Yahoo! DSL - Now only $29.95 per month! >>>>>http://sbc.yahoo.com >>>>> >>>>>--------------------------------------------------------------------- >>>>>To unsubscribe, e-mail: [EMAIL PROTECTED] >>>>>For additional commands, e-mail: [EMAIL PROTECTED] >>>>> >>>> >>>> >>>> >>>>--------------------------------------------------------------------- >>>>To unsubscribe, e-mail: [EMAIL PROTECTED] >>>>For additional commands, e-mail: [EMAIL PROTECTED] >>>> >>> >>> >>> >>>--------------------------------------------------------------------- >>>To unsubscribe, e-mail: [EMAIL PROTECTED] >>>For additional commands, e-mail: [EMAIL PROTECTED] >>> >> >> >> >>--------------------------------------------------------------------- >>To unsubscribe, e-mail: [EMAIL PROTECTED] >>For additional commands, e-mail: [EMAIL PROTECTED] >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
