Review: Needs Fixing
Diff comments:
> diff --git a/backend/msm/__init__.py b/backend/msm/__init__.py
> index 8506985..3651249 100644
> --- a/backend/msm/__init__.py
> +++ b/backend/msm/__init__.py
> @@ -1,8 +1,16 @@
> from pkg_resources import get_distribution
>
> -__all__ = ["PACKAGE", "__version__"]
> +__all__ = [
> + "PACKAGE",
> + "__version__",
> + "__default_page_size__",
> + "__max_page_size__",
> +]
>
>
> PACKAGE = get_distribution("msm")
>
> __version__ = PACKAGE.version
> +
> +__default_page_size__ = 20
these shouldn't be dunder variables
> +__max_page_size__ = 100
--
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/439629
Your team MAAS Committers is subscribed to branch
~thorsten-merten/maas-site-manager:MAASENG-1497-pagination.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : [email protected]
Unsubscribe : https://launchpad.net/~sts-sponsors
More help : https://help.launchpad.net/ListHelp
