[
https://issues.apache.org/jira/browse/SUBMARINE-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824808#comment-16824808
]
Szilard Nemeth edited comment on SUBMARINE-54 at 4/24/19 4:32 AM:
------------------------------------------------------------------
Hi [~tangzhankun]!
You are right, the jar is not generated at all!
Turns out I was using a wrong one, which was coming from a previous build on
trunk, see:
{code:java}
??-( szilardnemeth@snemeth-MBP[06:24:36] <0> @SUBMARINE-52-2 )--(
~/development/apache/hadoop )--
└-$ ll
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-submarine/target/hadoop-yarn-submarine-3.3.0-SNAPSHOT.jar
-rw-r--r-- 1 szilardnemeth staff 114343 Mar 12 19:33
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-submarine/target/hadoop-yarn-submarine-3.3.0-SNAPSHOT.jar
{code}
Also, find gives me these:
{code:java}
??-( szilardnemeth@snemeth-MBP[06:25:46] <0> @SUBMARINE-52-2 )--(
~/development/apache/hadoop )--
└-$ find . | grep ".*submarine.*jar"
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-submarine/target/hadoop-yarn-submarine-3.3.0-SNAPSHOT-sources.jar
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-submarine/target/hadoop-yarn-submarine-3.3.0-SNAPSHOT-test-sources.jar
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-submarine/target/hadoop-yarn-submarine-3.3.0-SNAPSHOT.jar
{code}
It can happen that I'm using a wrong build command, this is what I use:
{code:java}
mvn clean package -Pdist -DskipTests -Dmaven.javadoc.skip=true
{code}
Is there special mvn command we should use?
So I guess we should fix the jar first in order to try it out, right?
I can look into that.
was (Author: snemeth):
Hi [~tangzhankun]!
You are right, the jar is not generated at all!
Turns out I was using a wrong one, which was coming from a previous build on
trunk, see:
{code:java}
??-( szilardnemeth@snemeth-MBP[06:24:36] <0> @SUBMARINE-52-2 )--(
~/development/apache/hadoop )--
└-$ ll
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-submarine/target/hadoop-yarn-submarine-3.3.0-SNAPSHOT.jar
-rw-r--r-- 1 szilardnemeth staff 114343 Mar 12 19:33
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-submarine/target/hadoop-yarn-submarine-3.3.0-SNAPSHOT.jar
{code}
Also, find gives me these:
{code:java}
??-( szilardnemeth@snemeth-MBP[06:25:46] <0> @SUBMARINE-52-2 )--(
~/development/apache/hadoop )--
└-$ find . | grep ".*submarine.*jar"
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-submarine/target/hadoop-yarn-submarine-3.3.0-SNAPSHOT-sources.jar
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-submarine/target/hadoop-yarn-submarine-3.3.0-SNAPSHOT-test-sources.jar
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-submarine/target/hadoop-yarn-submarine-3.3.0-SNAPSHOT.jar
{code}
So I guess we should fix the jar first in order to try it out, right?
I can look into that.
> Add test coverage for YarnServiceJobSubmitter and make it ready for extension
> for PyTorch
> -----------------------------------------------------------------------------------------
>
> Key: SUBMARINE-54
> URL: https://issues.apache.org/jira/browse/SUBMARINE-54
> Project: Hadoop Submarine
> Issue Type: Sub-task
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: SUBMARINE-54.001.patch, SUBMARINE-54.002.patch,
> SUBMARINE-54.003.patch, SUBMARINE-54.004.patch, SUBMARINE-54.005.patch,
> SUBMARINE-54.006.patch, SUBMARINE-54.007.patch, SUBMARINE-54.008.patch,
> SUBMARINE-54.009.patch, SUBMARINE-54.009.patch
>
>
> This crucial class has no associated test yet. We need to improve this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
