[ 
https://issues.apache.org/jira/browse/SUBMARINE-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16842192#comment-16842192
 ] 

Peter Bacsko commented on SUBMARINE-69:
---------------------------------------

[~snemeth] two things:
 # Do we really need the variable {{zipIndex}} ? I think it makes more sense to 
create the temporary directory with a random name, eg. {{tempDir = 
fileUtils.createDirInTempDir("testDir_" + System.nanoTime());}}
 # Import classes directly instead of {{import static org.junit.Assert.*;}}

> Add tests to ZipUtilities class
> -------------------------------
>
>                 Key: SUBMARINE-69
>                 URL: https://issues.apache.org/jira/browse/SUBMARINE-69
>             Project: Hadoop Submarine
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Minor
>         Attachments: SUBMARINE-69.001.patch, SUBMARINE-69.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to