[ https://issues.apache.org/jira/browse/SUBMARINE-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Antal updated SUBMARINE-49: -------------------------------- Attachment: SUBMARINE-49.007.patch > Add more test coverage to RunJobParameters > ------------------------------------------ > > Key: SUBMARINE-49 > URL: https://issues.apache.org/jira/browse/SUBMARINE-49 > Project: Hadoop Submarine > Issue Type: Sub-task > Reporter: Szilard Nemeth > Assignee: Adam Antal > Priority: Major > Attachments: SUBMARINE-49.001.patch, SUBMARINE-49.002.patch, > SUBMARINE-49.003.patch, SUBMARINE-49.004.patch, SUBMARINE-49.004.patch, > SUBMARINE-49.005.patch, SUBMARINE-49.006.patch, SUBMARINE-49.007.patch, > SUBMARINE-49.007.patch > > > There are some good tests in > {{org.apache.hadoop.yarn.submarine.client.cli.TestRunJobCliParsing}}, but > these are not testing all fields set by method > {{org.apache.hadoop.yarn.submarine.client.cli.param.RunJobParameters#updateParametersByParsedCommandline}}. > > Some more extensive testing is needed in this area. > As an added bonus, the code > {{org.apache.hadoop.yarn.submarine.client.cli.param.RunJobParameters#updateParametersByParsedCommandline}} > could be cleaned up a bit. -- This message was sent by Atlassian JIRA (v7.6.3#76005)