[
https://issues.apache.org/jira/browse/SUBMARINE-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16882175#comment-16882175
]
Hadoop QA commented on SUBMARINE-66:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 13s{color}
| {color:red} SUBMARINE-66 does not apply to trunk. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SUBMARINE-66 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12974219/SUBMARINE-66.002.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-SUBMARINE-Build/145/console |
| versions | git=2.7.4 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
> Improve TF config env JSON generator + tests
> --------------------------------------------
>
> Key: SUBMARINE-66
> URL: https://issues.apache.org/jira/browse/SUBMARINE-66
> Project: Hadoop Submarine
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Adam Antal
> Priority: Major
> Attachments: SUBMARINE-66.001.patch, SUBMARINE-66.002.patch,
> SUBMARINE-66.002.patch
>
>
> org.apache.hadoop.yarn.submarine.runtimes.yarnservice.tensorflow.TensorFlowCommons#getTFConfigEnv
> generates a JSON of the TF_CONFIG environment variable.
> This code could be improved to use a JSON serializer instead of hand-crafting
> JSON data.
> The test class of this class also could be improved:
> org.apache.hadoop.yarn.submarine.runtimes.yarnservice.TestTFConfigGenerator
> In this class, there are some quite unreadable JSON strings, this could be
> refactored to be read out from a file instead.
> TestTFConfigGenerator has only one testcase and it's ugly, as we use very
> long strings to verify the JSON data produced matches our expected JSON.
> We should use JSON files instead of manually constructing Strings in tests,
> especially if they are very long.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
