[ https://issues.apache.org/jira/browse/SUBMARINE-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16882225#comment-16882225 ]
Hadoop QA commented on SUBMARINE-60: ------------------------------------ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 33s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m 0s{color} | {color:green} No case conflicting files found. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 24m 39s{color} | {color:green} trunk passed {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 38s{color} | {color:red} hadoop-submarine-yarnservice-runtime in trunk failed. {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 14s{color} | {color:orange} The patch fails to run checkstyle in hadoop-submarine-yarnservice-runtime {color} | | {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m 16s{color} | {color:red} hadoop-submarine-yarnservice-runtime in trunk failed. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 10m 28s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 15s{color} | {color:red} hadoop-submarine-yarnservice-runtime in trunk failed. {color} | | {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 11m 1s{color} | {color:blue} Used deprecated FindBugs config; considering switching to SpotBugs. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 17s{color} | {color:red} hadoop-submarine-yarnservice-runtime in trunk failed. {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 11s{color} | {color:red} hadoop-submarine-yarnservice-runtime in the patch failed. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 11s{color} | {color:red} hadoop-submarine-yarnservice-runtime in the patch failed. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 11s{color} | {color:red} hadoop-submarine-yarnservice-runtime in the patch failed. {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 7s{color} | {color:orange} The patch fails to run checkstyle in hadoop-submarine-yarnservice-runtime {color} | | {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m 11s{color} | {color:red} hadoop-submarine-yarnservice-runtime in the patch failed. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 38s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 12s{color} | {color:red} hadoop-submarine-yarnservice-runtime in the patch failed. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 13s{color} | {color:red} hadoop-submarine-yarnservice-runtime in the patch failed. {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 13s{color} | {color:red} hadoop-submarine-yarnservice-runtime in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 30s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 51m 26s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/PreCommit-SUBMARINE-Build/150/artifact/out/Dockerfile | | JIRA Issue | SUBMARINE-60 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12974220/SUBMARINE-60.003.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 3f31dd9e32db 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / bbf5844 | | Default Java | 1.8.0_212 | | compile | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/150/artifact/out/branch-compile-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt | | checkstyle | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/150/artifact/out//home/jenkins/jenkins-slave/workspace/PreCommit-SUBMARINE-Build/out/maven-branch-checkstyle-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt | | mvnsite | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/150/artifact/out/branch-mvnsite-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt | | javadoc | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/150/artifact/out/branch-javadoc-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt | | findbugs | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/150/artifact/out/branch-findbugs-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt | | mvninstall | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/150/artifact/out/patch-mvninstall-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt | | compile | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/150/artifact/out/patch-compile-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt | | javac | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/150/artifact/out/patch-compile-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt | | checkstyle | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/150/artifact/out//home/jenkins/jenkins-slave/workspace/PreCommit-SUBMARINE-Build/out/maven-patch-checkstyle-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt | | mvnsite | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/150/artifact/out/patch-mvnsite-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt | | javadoc | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/150/artifact/out/patch-javadoc-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt | | findbugs | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/150/artifact/out/patch-findbugs-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt | | unit | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/150/artifact/out/patch-unit-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt | | Test Results | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/150/testReport/ | | Max. process+thread count | 412 (vs. ulimit of 10000) | | modules | C: hadoop-submarine/hadoop-submarine-yarnservice-runtime U: hadoop-submarine/hadoop-submarine-yarnservice-runtime | | Console output | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/150/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. > Remove stubServiceClient from YarnServiceUtils > ---------------------------------------------- > > Key: SUBMARINE-60 > URL: https://issues.apache.org/jira/browse/SUBMARINE-60 > Project: Hadoop Submarine > Issue Type: Improvement > Reporter: Szilard Nemeth > Assignee: Adam Antal > Priority: Major > Attachments: SUBMARINE-60.001.patch, SUBMARINE-60.002.patch, > SUBMARINE-60.002.patch, SUBMARINE-60.003.patch, SUBMARINE-60.003.patch > > > We have a field in YarnServiceUtils: > org.apache.hadoop.yarn.submarine.runtimes.yarnservice.YarnServiceUtils#stubServiceClient > There's a setter for this field, marked with VisibleForTesting and the test > code uses this setter to set the value of this field to a mock. > Then, when createServiceClient gets called from the production code, it first > checks if we have this field set. If so, we return it, otherwise we create a > normal app admin client. > This is an anti-pattern to just have test-related fields or methods in the > production code. > > Currently, YarnServiceJobSubmitter and YarnServiceJobMonitor are the only > users of > org.apache.hadoop.yarn.submarine.runtimes.yarnservice.YarnServiceUtils#createServiceClient. > This static could be easily replaced with a factory that receives the current > Configuration object then returns the AppAdminClient. The test should inject > the mock factory either via the constructor or with a setter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)