On Mar 7, 2014 5:42 AM, "Tomaz Canabrava" <tcanabr...@kde.org> wrote: > > can anybody recheck this for me? from what Linus wrote, this should work for libgit2 0.20, but I had to extend his macro to check the libgitversion to be <= 20.
You are probably right that it should be <= 20. I only tested 0.19 and my self-built libgit tree, and the libgit versioning is horrible. The API documentation on the web tries to show when the API changed, but when you click on the different version numbers to see the actual API for that version, it seems to randomly give some random version. But the color coding on the API web docs does imply that the change happened between 0.20 and current HEAD. So I think <= 20 is OK, but breaks HEAD because the version hasn't been incremented to 21 yet. But let's aim to primarily support actual releases rather than Git tree of the day. To make things worse, my googling showed at least one libgit developer saying these breakages are OK, because it's not 1.0 yet. People like that shouldn't write libraries. Oh well. As Dirk mentioned, we used to have similar problems with libdivecomputer. The libgit people probably don't have enough external users to see there error of their ways. Linus
_______________________________________________ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface