On Tue, 2014-03-25 at 15:09 +0200, Gehad wrote: > I'm waiting for your appreciated reviews and feedback.
I haven't tried the patch, just looked at the code so far. There are some odd white space (space between comma and next argument, for example) and line breaking decisions in there, especially with the continuation lines in the fputs statements... Can you explain those? But in general, I don't really like all these fputs (what a silly API with the FILE* argument as second argument) - we really should just assemble the strings and then write them to the file. Also, maybe I'm just not tracking (-ENOTENOUGHCOFFEE) but what's the purpose? /D _______________________________________________ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface