On Sun, 2014-05-04 at 21:02 +0200, Lutz Vieweg wrote: > On 05/04/2014 08:41 PM, Dirk Hohndel wrote:
> >> I just noticed that Subsurface puts a strange label besides pO2 alerts > >> from the Suunto D9: It says "bailing out to OC", which seems strange, > >> given those were OC dives all the time. > > > > Umm... I think I know how this happened... I just wonder why... need to > > go back and look at those changes. > > > > Can you send me the event line from one of your D9 XML files? > > Sure: > <event time='21:49 min' type='20' flags='1' name='PO2' /> > <event time='22:12 min' type='20' flags='2' name='PO2' /> > > The "flags" values don't seem to matter, both events are displayed > with the same text. OK, just pushed the fix. We are abusing an event type from libdivecomputer inside Subsurface. We simply use a different name for it. Instead of the PO2 warning it now is a set point change. When I fixed support for translated event names I changed all instances where we compared against names to compare against types. Oops. Kaboom. I asked Jef for a way to create 'private' event types for Subsurface. And I hacked around the issue for the time being by once again checking against the event name. /D _______________________________________________ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface