Can you post sample screenshots of both versions? Compiling code will have to wait a bit for me...
Miika Hi, This is a patch on the top of the 4 patches I sent two days ago. This mainly changes the profile to Highchart graph instead of the HTML5 canvas, This patch still needs more working and format and style fixing. Also I need to add another Data to the JSON file. But I send it now so you can compare between the HTML5 canvas and the Highchart graph, so we can decide which on to work with. Also I didn't add Highcharts Javascript files to the project yet, I load them to the page online so the this will need Internet to work. Please tell me how do you find this? are the curves sketched correctly? I don't understand the semantics of these curves very well so any feedback from you will be appreciated for sure. Regards, Gehad On Tue, Jun 17, 2014 at 6:31 AM, Miika Turkia <miika.tur...@gmail.com> wrote: > On Tue, Jun 17, 2014 at 1:12 AM, Gehad Elrobey <gehadelro...@gmail.com> > wrote: > >> >> >> >> On Sun, Jun 15, 2014 at 7:55 AM, Miika Turkia <miika.tur...@gmail.com> >> wrote: >> >>> Here is the latest set of Gehad's patches with my singed-off included. I >>> have also some comments here. >>> >>> - You delete the theme.css but not the other template files when >>> copying? If any other of the template files has changed in Subsurface, they >>> are not updated. >>> - The detailed view does not work for manually added dives. >>> >>> >> >> Manual add dives work ok with me, can you send me the dive file please? >> > > I seem to be getting the following error on JS Error Console: > > TypeError: end is undefined list_lib.js:715 > > A sample dive attached. > >> >> >> >>> There is also one whitespace issue, but it seems to be someone else's >>> doing. (It seems that the whitespace checker scrips works reasonably well >>> on JS files. And it really should be run against those as well, as there is >>> quite a bit of inconsistent spacing in there. When running it we'll just >>> need to be extra careful to make sure it is only "cosmetic" changes that >>> occur.) >>> >>> >> >> I Attached some patches to fix the JS format and checked that it doesn't >> corrupt anything. >> Also Fixed the deletion of other template files. >> > > Looks good whan taking a very quick peek at the files. I'll take another > look later. > > miika > >
_______________________________________________ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface