Looking good, but some more improvements needed after a brief test: - When I export dives from one trip only, the trip mode sorting shows all the exported dives under other. - The yearly statistics layout needs some work, at least on my FF 30.0 - The table is too wide for my 1600 pix wide screen as a lot of space is wasted on the cells unnecessarily - Total time is wrapped too much as shown on attached screenshot
I'll re-send the current patch set with my SOB later today. miika On Mon, Aug 4, 2014 at 5:03 PM, Gehad Elrobey <gehadelro...@gmail.com> wrote: > Hi Miika, > > Sorry for the delay, I had some family vacations this week. > I Implemented the yearly statistics into the HTML exports (Patches are > attached), also there are some patches not applied to current master yet.. > I am waiting your feedback. > > Regards, > Gehad > > > On Mon, Jul 28, 2014 at 5:14 PM, Miika Turkia <miika.tur...@gmail.com> > wrote: > >> Thanks, you had one 'return' missing, which I added and did some >> rewording on the commit messages. >> >> The lines on the horizontal axis are a bit weird currently. Shown on the >> attached screenshot. The depth and pressure units get misaligned due to the >> static temperature fix (I guess). >> >> miika >> >> >> >> On Sun, Jul 27, 2014 at 11:01 PM, Gehad Elrobey <gehadelro...@gmail.com> >> wrote: >> >>> I Attached four patches that fix the mentioned bugs. I ll still work on >>> more improvements for the current javascript code. >>> >>> Regards, >>> Gehad >>> >>> >>> On Fri, Jul 25, 2014 at 8:02 AM, Miika Turkia <miika.tur...@gmail.com> >>> wrote: >>> >>>> On Thu, Jul 24, 2014 at 10:29 PM, Gehad Elrobey <gehadelro...@gmail.com >>>> > wrote: >>>> >>>>> >>>>> I attached a patch with two more fixes. >>>>> Now most of the bugs list seems to be resolved. >>>>> >>>> >>>> It seems that the temperature graph is not drawn, if the temperature is >>>> constant the whole dive. >>>> >>>> The layout seems to change for me when I open a dive on the divelist. >>>> This is due to scrollbar appears on the browser window. If you could come >>>> up with something that keeps the layout the same in this case. This >>>> requires on my screen that I export just a few dives, having 10 dives on >>>> the page causes the scroll bar to be there to begin with. >>>> >>>> Could give a - as value for such events that don't have any sensible >>>> values. I suppose that heading is the only event where value 0 makes sense. >>>> >>>> Dive equipments seems to only include the cylinder information. It >>>> could have also weight and suite... or the title should be changed to >>>> cylinder. >>>> >>>> >>>> >>>>> what do you recommend to be added for now? and what things are missing >>>>> or need to be fixed as a priority? >>>>> >>>> >>>> A statistics page could be next one to implement. Yearly and trip based >>>> stats of the key values. You could also implement something that is >>>> currently missing from Subsurface GUI - statistics of how many specific >>>> tags are there, how many dives with certain buddies etc. One could come up >>>> with quite a few ideas about how to graph different statistics out of the >>>> date that is kept... But take small steps implementing this stuff. Better >>>> to have basic stuff properly implemented first than a whole lot of >>>> incomplete mess... >>>> >>>> >>>>> On Mon, Jul 21, 2014 at 7:32 AM, Miika Turkia <miika.tur...@gmail.com> >>>>> wrote: >>>>> >>>>>> On Mon, Jul 21, 2014 at 8:16 AM, Gehad Elrobey < >>>>>> gehadelro...@gmail.com> wrote: >>>>>> >>>>>>> >>>>>>> Hi miika, >>>>>>> >>>>>>> On Sun, Jul 20, 2014 at 8:02 AM, Miika Turkia < >>>>>>> miika.tur...@gmail.com> wrote: >>>>>>> >>>>>>>> New bugs I spotted: >>>>>>>> >>>>>>>> - The tooltip on temperature graphs shows actually the time >>>>>>>> (concatenated with temperature unit). >>>>>>>> >>>>>>> >>>>>>> what is it supposed to show? I think this is consistent will all the >>>>>>> other curves in the profile. >>>>>>> >>>>>> >>>>>> It should show the temperature value. The temperature graph is drawn >>>>>> based on the temperature correctly, but the tooltip shows time since >>>>>> start >>>>>> of the time, not the temperature. >>>>>> >>>>> >>>>> I Can't reproduce this at all, this is working correctly with me in >>>>> all the dives I have (Please see the attachments). >>>>> >>>> >>>> Seems that I mis-read the value - thought the time is part of the >>>> temperature. Maybe you could use colon instead of comma to separate the >>>> time from the actual value. It would be a bit clearer that it is not 8,6 C >>>> :D >>>> >>>> miika >>>> >>>>> >>>>> >>>>>> >>>>>> >>>>>>> I Also fixed the previous patches, and attached some new patches >>>>>>> with them. >>>>>>> There are still three bugs that I am working on them now. >>>>>>> >>>>>> >>>>>> Thanks, I'll have a look later. >>>>>> >>>>>> >>>>>>> - I am not sure about the search of location - e.g. if I write >>>>>>>> "Mexico somethingthatdoesnotexist", I get all the locations in Mexico. >>>>>>>> - Zooming in (ctrl++) and out (ctrl+-) and restoring zoom level >>>>>>>> (ctrl+0) on firefox does not rescale the graph properly >>>>>>>> - The heading and gaschange switches should use the value field >>>>>>>> from the event, not the type field (type is still internal to >>>>>>>> subsurface, >>>>>>>> and does not provide any useful information to the users, on the other >>>>>>>> hand >>>>>>>> value would e.g. tell what gas we changed to) >>>>>>>> >>>>>>> >>>>>>> Regarding the event value, is exporting the event value as a number >>>>>>> is useful? or there is some enum strings that must be shown instead? >>>>>>> >>>>>> >>>>>> The heading is degrees, as in compass. >>>>>> >>>>>> The gas change event's value contains the o2 per centage, of the gas >>>>>> mix, or it can also contain the o2 and he content. Low order bits being >>>>>> o2 >>>>>> and high order bits the he: >>>>>> he = cur_event.value >> 16 >>>>>> o2 = cur_event.value & 0xffff >>>>>> >>>>>> miika >>>>>> >>>>>> >>>>>>> - If I go to next dive on detailed view, and hit one extra right >>>>>>>> arrows after reaching the last dive, first click on left does not >>>>>>>> change >>>>>>>> the selection, only re-clicking on left does >>>>>>>> >>>>>>>> I'll still do a bit of poking around once I have more time... >>>>>>>> >>>>>>>> miika >>>>>>>> >>>>>>>> >>>>>>>> On Sat, Jul 19, 2014 at 6:30 AM, Gehad Elrobey < >>>>>>>> gehadelro...@gmail.com> wrote: >>>>>>>> >>>>>>>>> I Attached some bug fixes, Still working on the remaining bugs. >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> Gehad. >>>>>>>>> >>>>>>>>> >>>>>>>>> On Tue, Jul 15, 2014 at 11:22 PM, Tomaz Canabrava < >>>>>>>>> tcanabr...@kde.org> wrote: >>>>>>>>> >>>>>>>>>> On Tue, Jul 15, 2014 at 4:31 PM, Anton Lundin <gla...@acc.umu.se> >>>>>>>>>> wrote: >>>>>>>>>> > On 15 July, 2014 - Anton Lundin wrote: >>>>>>>>>> > >>>>>>>>>> >> On 15 July, 2014 - Miika Turkia wrote: >>>>>>>>>> >> >>>>>>>>>> >> > A few more bugs: >>>>>>>>>> >> > - Trimix dives are missing He content (use e.g. test20.xml >>>>>>>>>> for testing >>>>>>>>>> >> > purposes) - Reported by Roberto, but mailing list was not >>>>>>>>>> included >>>>>>>>>> >> >>>>>>>>>> >> Gaah. This is code that uses the event data straight off. In >>>>>>>>>> the case of >>>>>>>>>> >> SAMPLE_EVENT_GASCHANGE especially we need to map the event to >>>>>>>>>> the >>>>>>>>>> >> available cylinders and that way figure out which gas we are >>>>>>>>>> using. >>>>>>>>>> >> >>>>>>>>>> >> Almost every place where we use get_gasmix_from_event we >>>>>>>>>> should be using >>>>>>>>>> >> get_cylinder_index instead and grab the "real" gasmix from the >>>>>>>>>> cylinder, >>>>>>>>>> >> except the case where get_gasmix_from_event is called from >>>>>>>>>> >> get_cylinder_index =) >>>>>>>>>> >> >>>>>>>>>> >> >>>>>>>>>> >> This was more work than anticipated when i first gave it a >>>>>>>>>> stab. If no >>>>>>>>>> >> one else untangles this I'll give it another stab later. >>>>>>>>>> >> >>>>>>>>>> >> >>>>>>>>>> > >>>>>>>>>> > Gaah 2. >>>>>>>>>> > >>>>>>>>>> > I of course miss-read the report and i was talking about what >>>>>>>>>> we write >>>>>>>>>> > in the regular-non-html-ui. >>>>>>>>>> > >>>>>>>>>> > I found another bug. >>>>>>>>>> >>>>>>>>>> :P >>>>>>>>>> >>>>>>>>>> > //Anton >>>>>>>>>> _______________________________________________ >>>>>>>>>> subsurface mailing list >>>>>>>>>> subsurface@hohndel.org >>>>>>>>>> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> >
_______________________________________________ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface