On Thu, Aug 14, 2014 at 7:10 PM, Dirk Hohndel <d...@hohndel.org> wrote:
>
> - mouse hover overlay:
> the lack of units for time is a bit confusing, at first I wondered why I
> had 2,185bar in my tank at the beginning of the dive (and was briefly
> wondering about a bar/psi mixup).
>
Totally agree, a colon (:) would also help as I have mentioned earlier.
Anyway "2s: 185bar" would probably make this very obvious.
>
> - Location / undefined
> with current master I get "Date:... Time:... undefined:...
> Coordinates:..."
> I bet that's supposed to say "Divesite" or "Location" or something :-)
>
This is partly my fault as I fixed typo on Location with the previous set
of patches. Somehow the same typo sneaked back in with this set of patches.
I have attached a typo fix here again...
>
> Now I realize this reads like a long list of complaints. Please take it as
> input in making things even better. Some of them (like the "undefined"
> instead of location) should be trivial fixes - actually most of them with
> maybe the exception of imperial units should be fairly easy, but that's
> the point. These are all minor issues in an overall very successful
> project!
>
At least you remember to give praise where it is due. I have also been
happy with Gehad's progress and results!
One thing that should have been done differently is bugs and enhancement
requests. We should have created tickets on bugtracker of all the issues
instead of just listing them on emails. I haven't been able to follow all
the issues I have mentioned and I am sure it is even harder for Gehad...
miika
From 2dfc869eaccbae285c9c96f9b65643f957ae41be Mon Sep 17 00:00:00 2001
From: Miika Turkia <miika.tur...@gmail.com>
Date: Thu, 14 Aug 2014 19:28:24 +0300
Subject: [PATCH] Fix typo
Signed-off-by: Miika Turkia <miika.tur...@gmail.com>
---
theme/list_lib.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/theme/list_lib.js b/theme/list_lib.js
index c5171ce..6e5dc87 100644
--- a/theme/list_lib.js
+++ b/theme/list_lib.js
@@ -208,7 +208,7 @@ function getExpanded(dive)
{
var res = '<table><tr><td class="words">' + translate.Date + ': </td><td>' + dive.date +
'</td><td class="words"> ' + translate.Time + ': </td><td>' + dive.time +
- '</td><td class="words"> ' + translate.Locaiton + ': </td><td>' + '<a onclick=\"Search_list_Modules(\'' + dive.location + '\', {location:true, divemaster:false, buddy:false, notes:false, tags:false,})\">' + dive.location + '</a>' + getDiveCoor(dive) +
+ '</td><td class="words"> ' + translate.Location + ': </td><td>' + '<a onclick=\"Search_list_Modules(\'' + dive.location + '\', {location:true, divemaster:false, buddy:false, notes:false, tags:false,})\">' + dive.location + '</a>' + getDiveCoor(dive) +
'</td></tr></table><table><tr><td class="words">' + translate.Rating + ':</td><td>' + putRating(dive.rating) +
'</td><td class="words"> ' + translate.Visibility + ':</td><td>' + putRating(dive.visibility) +
'</td></tr></table>' +
@@ -918,7 +918,7 @@ function get_dive_HTML(dive)
{
var res = '<h2 class="det_hed">' + translate.Dive_information + '</h2><table><tr><td class="words">' + translate.Date + ': </td><td>' + dive.date +
'</td><td class="words"> ' + translate.Time + ': </td><td>' + dive.time +
- '</td><td class="words"> ' + translate.Locaiton + ': </td><td>' + '<a onclick=\"Search_list_Modules(\'' + dive.location + '\', {location:true, divemaster:false, buddy:false, notes:false, tags:false,})\">' + dive.location + '</a></td>' + getDiveCoor(dive) +
+ '</td><td class="words"> ' + translate.Location + ': </td><td>' + '<a onclick=\"Search_list_Modules(\'' + dive.location + '\', {location:true, divemaster:false, buddy:false, notes:false, tags:false,})\">' + dive.location + '</a></td>' + getDiveCoor(dive) +
'</tr></table><table><tr><td class="words">' + translate.Rating + ':</td><td>' + putRating(dive.rating) +
'</td><td class="words"> ' + translate.Visibility + ':</td><td>' + putRating(dive.visibility) +
'</td></tr></table>' +
--
1.9.1
_______________________________________________
subsurface mailing list
subsurface@hohndel.org
http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
