On Sat, Nov 15, 2014 at 09:19:28AM -0800, Linus Torvalds wrote:
> On Nov 15, 2014 2:20 AM, "Miika Turkia" <miika.tur...@gmail.com> wrote:
> >
> > If start and end cylinder pressure is not explicitly set for secondary
> > cylinders, we must store the start and end pressures from the
> > sample_{start,end} attribute. Faulty behavior is obvious at least when
> > importing Poseidon logs.
>
> This is not how is supposed to work.
>
> If we have cylinder sample data, we don't save start/end pressures per
> cylinder, we get them from the samples.
>
> The saved cylinder pressures are supposed to happen only if the user did
> some manual overriding (maybe there is sample data, but it was incomplete
> and the transmitter flaked out in the middle of the dive), or if there is
> no sample data and the user entered it manually.
Thanks for catching this... I confused myself with the other patches... I
thought this was because in the CCR case we deal with two different
cylinders but only have sample data for one but that's not what this
commit is about, so Linus is correct. Don't save redundant data.
I'll revert.
/D
_______________________________________________
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
