On Tue, May 12, 2015 at 11:24 AM, Lubomir I. Ivanov <neolit...@gmail.com> wrote:
> On 7 May 2015 at 09:28, Lubomir I. Ivanov <neolit...@gmail.com> wrote: > > Dirk and others, what do you think - should we make this new library > > dependency (Grantlee) optional like we do with Marble? > > Should the printing be completely disabled if the user decides to > > build with NO_GRANTLEE or should we fall back to the current Qt-only > > based printing (creates bloat as we are going to have 2 printing > > modules)? > > > > also GSoC wise, do you think the new printing code should enter master > > while WIP or should it do so all at once when mostly done? > > > > hello Gehad, > > to summarize what Drik just confirmed: > - we use NO_GRANTLEE and align it to NO_PRINTING i.e. if Grantlee is > not used we don't allow printing. > - only one printing module at a time. we only work on the new printing > module and replace the old one completely! > - we can still use Github for the reviews, but we are going to make > pull requests more often, so that people can test the code in master. > - once i review certain patches, i'm going to pull them in my github, > sign them off and send the pull requests myself > > having said that i need to find more free time to do the reviews! > > lubomir > -- > Hello Lubomir, ACK, thanks for the clarification. -- regards, Gehad
_______________________________________________ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface