On 2 June 2015 at 15:19, Gehad Elrobey <gehadelro...@gmail.com> wrote:
>
> I have removed the QObject inheritance from my Dive class and pushed to my
> branch.
>

i've just sent a pull request; namely:
[PULL REQUEST] GSoC Printing: initial batch of patches

modified your commit messages at places.
don't mind me skipping upper case letters all the time here, commit
messages should be formatted well.

- names such as Subsurface and Grantlee are upper case
- proper capitalization of sentence starts everywhere
- it's usually better to have a commit message than not having one

please, monitor that thread and let see if we need to amend something.

lubomir
--
_______________________________________________
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Reply via email to