On Thu, Jun 04, 2015 at 05:58:10PM +0300, Lubomir I. Ivanov wrote: > So this is the initial work from Gehad. I'm looking forward to getting this in > master as he needs to continute the work into the template specific logic. > Rebasing all the time while waiting on me for reviews must be a pain, so this > is pending.
OK, I added a few comments, some are arguably cosmetic, some are about hardcoding things. None should prevent me from pulling this in order to make your life easier. But please make it a high priority to address the comments I made on github. I will however turn this code off by default until we figured out the building of Grantlee > As discussed this does break the current printing module in the expense of > not maintaining a couple of modules (old vs new) durring GSoC. > For users that follow master and don't want to install Grantlee please use > "cmake -DNO_PRINTING" but mind that Grantlee will be a hard dependency if you > ever want to print with Subsurface. Nope, for now we'll do it the other way around. You'll need to add -DNO_PRINTING=OFF in order to enable this in master > Some of the patches at this point simply remove old code and add some of the > new logic which is WIP for the time being. > > Earlier today I've sent another patch, which is for the sake of me being able > to build with NO_MARBLE: > [PATCH] GlobeGPS: add empty function for NO_MARBLE I'll add that one as well. /D _______________________________________________ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface