On 14 July 2015 at 14:29, Lubomir I. Ivanov <neolit...@gmail.com> wrote: > On 14 July 2015 at 13:19, Gehad Elrobey <gehadelro...@gmail.com> wrote: >> >> On Jul 14, 2015 12:15 PM, "Lubomir I. Ivanov" <neolit...@gmail.com> wrote: >>> >>> On 14 July 2015 at 00:16, Gehad Elrobey <gehadelro...@gmail.com> wrote: >>> > >>> > Should I convert the dive profile to QImage during previewing only or >>> > should >>> > I convert it during actual printing also which will affect the printing >>> > quality? >>> > >>> >>> i can't build ATM, but i think the logic here is a bit wrong: >>> >>> https://github.com/Gehadelrobey/subsurface/commit/d5b9e8424f82f4960d44a2f16abda1cbf27d7673 >>> >>> "We must pass a QPaintDevice with type QPixmap for previewing and with >>> type QPrinter for actual printing." >>> >>> does that include QPrintPreviewDialog as well? if so that's wrong. >>> you can use a QPixmap if you are rendering an image to be shown in the >>> template edit dialog, but the actual QPrintPreviewDialog contents >>> should be pretty much the same as the printed contents (on a hardcopy >>> or in a PDF). >>> >> >> No, the preview function is used for the QPixmap in the TemplateEdit only, >> while the QPrintPreviewDialog uses the actual print() function. > > both the preview and print profiles are in vector for me, which is good. > also the color and edit seems to be working and the preferred colors > are stored (in the settings/registry(win32), apparently). > > we *might* have to get some user feedback on the colors...i think > storing them globally is a bad idea. > will create a thread on the ML for that. >
never mind, this is a tricky one. i'm just going to leave it be for now, so that users can actually test it from master eventually. can we at least have names for the colors (e.g. "Background", "Table"...etc) instead of "color 1", "color 2"...? lubomir -- _______________________________________________ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
