On Mon, Aug 24, 2015 at 11:20:29AM +0300, Claudiu Olteanu wrote: > Sorry for the late response but I didn't have access to Internet for the > last three days. > > Thiago, thanks again for the review. I saw that the patches are now in > the upstream. > > Dirk, if you think that it is necessary I can send you another patch using > the WSAStringToAddressW (like Thiago suggested), or forcing the cast > from const char* to char * (like Lubomir suggested) and continue to use the > WSAStringAddressA function.
Obviously this is past the GSoC end, so we are now moving from "you are a GSoC student" to "you are one of our top contributors". Which means this is your decision :-) I think I lean slightly towards the WSAStringToAddressW solution as it seems a bit more elegant (if anything in the Windows API is ever elegant). /D _______________________________________________ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface