On Tue, Nov 03, 2015 at 02:43:50PM +0200, Lubomir I. Ivanov wrote: > On 3 November 2015 at 06:24, Miika Turkia <miika.tur...@gmail.com> wrote: > > > > I would not be surprised, if there was still something more lurking > > around... > > yours and Linus' patches make the file work. > i'm sure everyone has noticed that the parsing of this file slow as > heck, though...and it locks the UI, which could make the user think > the app has hanged. :\
Yes, this definitely needs some kind of progress indicator. A secondary concern would be some profiling to figure out WHY it takes so bloody long, but frankly, this is a corner case / rare use case so I'm not as worked up about this. But we definitely need a progress indicator. > like mentioned in one of my previous emails there is something wrong > when parsing depths. i get a lot of: > "Strange depth reading NaN m" > > probably due to some of the samples in the XSLT output being: > <sample time="" depth="NaN m"/> Miika, can we just skip those? A depth that is Not a Number isn't really all that interesting... And please, don't get me started on software that writes shit like this into a data file. /D _______________________________________________ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface