On Wednesday, November 18, 2015 11:47:00 PM Lubomir I. Ivanov wrote: > From: "Lubomir I. Ivanov" <[email protected]> > > Testing the mobile application on Win32 desktop results > in a crash. > > Using ApplicationWindow for some reason makes the executable > enter an inifinity loop on startup until it runs out of RAM. > The output is: > > setGeometryDp: Unable to set geometry 160x1200+720+426 on ApplicationWindow_ > QMLTYPE_12_QML_111/''. Resulting geometry: 160x885+720+426 (frame: 4, 23, > 4, 4, custom margin: 0, 0, 0, 0, minimum size: 0x47, maximum size: > 16777215x 16777215). > > To fix the crash use "Window" instead of "ApplicationWindow". > > Suggested-by: Sebastian Kugler <[email protected]> > Signed-off-by: Lubomir I. Ivanov <[email protected]> > --- > > please ignore, if Sebastian has already implemented the change > in his branches/patches.
I haven't, but it's OK. The difference between Window and ApplicationWindow is that the latter has some more properties, which we currently don't use. I'm cool with moving to Window for that, *but* we may return to ApplicationWindow in the future, for better platform integration of things like menus. Let's prevent that crasher for now, though. Holler if I introduce it without checkout with you that the crashes aren't still an issue. I'm not 100% sure about the sign-off procedure, but in case you need it, here's my line: Signed-off-by: Sebastian Kügler <[email protected]> Thanks for the patch! > --- > qt-mobile/qml/main.qml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qt-mobile/qml/main.qml b/qt-mobile/qml/main.qml > index f28a579..c3117b9 100644 > --- a/qt-mobile/qml/main.qml > +++ b/qt-mobile/qml/main.qml > @@ -9,7 +9,7 @@ import org.subsurfacedivelog.mobile 1.0 > import "qrc:/qml/theme" as Theme > > > -ApplicationWindow { > +Window { -- sebas http://www.kde.org | http://vizZzion.org _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
