On 28 July 2017 at 04:15, Lubomir I. Ivanov <neolit...@gmail.com> wrote: > On 28 July 2017 at 04:07, Dirk Hohndel <d...@hohndel.org> wrote: >> >> I have done a somewhat coarse review of the code. A few minuscule complaints, >> mostly about commit message formatting and random white space and coding >> style things, but nothing of substance that I noticed reading the code. >> >> I think I'll pull this today (just waiting for a note from Lubomir that he's >> ready for >> me) and then we can all test this. >> >> This may break things, but it looks really, really promising. >> >> Of course, having this in Subsurface-mobile would be spectacular :-) >> > > thanks, as noted @ github it's best that i update the PR tomorrow (as it's > 4am). > will ping back when ready; probably around 17:00 CES. >
done with the changes and rebased the PR. i also fixed some commit message typos. lubomir -- _______________________________________________ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
