Re: [PATCH 2/2] Properly clear sensor pressure data for synthetic plotinfo entries

[Stefan Fuchs]

Hi Linus, hallo Robert,

sorry, me again regarding the wrong pressure data graph or let's better
say wrong pressure data entry in the XML file where Linus did a pretty
extensive analysis.

Am 15.09.2017 um 20:22 schrieb Linus Torvalds:
> On Fri, Sep 15, 2017 at 5:31 AM, Stefan Fuchs <sfu...@gmx.de> wrote:
>> Sorry for the maybe stupid questions: This does already solve the issue with
>> the spike I reported, isn't it?
> Maybe. I'm not convinced it didn't exist before, though, although
> maybe hidden. It definitely existed as far as the o2pressure was
> concerned, since that wasn't cleared before either.
I can still create one interesting situation where I finally will have
the issue (all related files are attached):
- I plan a new dive of the specific kind (deco gas used as first gas and
then used later again) with the planner and save it to a new XML file
  --> Everything ok, no vertical line in graph, in XML at time of gas
change 43:35 there is no pressure value. This is as Linus said it should be.
- I close Subsurface, restart, open XML
  --> Everything ok, no vertical line in graph
- Replan dive in planner
  --> Vertical line at ~43min appears and if I now save this and look in
the XML a pressure value was added at 43:35 which is incorrect.

The question is now: Why does the planner (or whatever) does the thing
correctly when creating the dive but then does a mistake when replanning
the same dive?


Best regards
Stefan

-- 

Stefan Fuchs
E-Mail: sfu...@gmx.de <mailto:sfu...@gmx.de>


<divelog program='subsurface' version='3'>
<settings>
</settings>
<divesites>
</divesites>
<dives>
<dive number='1' date='2017-09-20' time='10:49:57' duration='75:16 min'>
  <notes>&lt;div&gt;&lt;b&gt;Subsurface (4.6.4.842) Plan&lt;/b&gt; erstellt am 
20.09.17&lt;/b&gt;&lt;br&gt;Runtime: 
75min&lt;br&gt;&lt;/div&gt;&lt;table&gt;&lt;thead&gt;&lt;tr&gt;&lt;th&gt;&lt;/th&gt;&lt;th&gt;Tiefe&lt;/th&gt;&lt;th
 style='padding-left: 10px;'&gt;Dauer&lt;/th&gt;&lt;th style='padding-left: 
10px;'&gt;Runtime&lt;/th&gt;&lt;th style='padding-left: 10px; float: 
left;'&gt;Gas&lt;/th&gt;&lt;/tr&gt;&lt;/thead&gt;&lt;tbody style='float: 
left;'&gt;&lt;tr&gt;&lt;td style='padding-left: 10px; float: 
right;'&gt;&amp;#10136;&lt;/td&gt;&lt;td style='padding-left: 10px; float: 
right;'&gt; 15m&lt;/td&gt;&lt;td style='padding-left: 10px; float: right;'&gt;  
5min&lt;/td&gt;&lt;td style='padding-left: 10px; float: right;'&gt;  
5min&lt;/td&gt;&lt;td style='padding-left: 10px; color: red; float: 
left;'&gt;&lt;b&gt;EAN50&lt;/b&gt;&lt;/td&gt;&lt;/tr&gt;&lt;tr&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;&amp;#10137;&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 15m&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;  5min&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 10min&lt;/td&gt;&lt;td 
style='padding-left: 10px; color: red; float: 
left;'&gt;&lt;b&gt;(21/35)&lt;/b&gt;&lt;/td&gt;&lt;/tr&gt;&lt;tr&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;&amp;#10136;&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 45m&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;  5min&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 
15min&lt;/td&gt;&lt;td&gt;&amp;nbsp;&lt;/td&gt;&lt;/tr&gt;&lt;tr&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;&amp;#10137;&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 45m&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 25min&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 
40min&lt;/td&gt;&lt;td&gt;&amp;nbsp;&lt;/td&gt;&lt;/tr&gt;&lt;tr&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;&amp;#10138;&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 21m&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;  4min&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 
44min&lt;/td&gt;&lt;td&gt;&amp;nbsp;&lt;/td&gt;&lt;/tr&gt;&lt;tr&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;-&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 21m&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;  5min&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 49min&lt;/td&gt;&lt;td 
style='padding-left: 10px; color: red; float: 
left;'&gt;&lt;b&gt;EAN50&lt;/b&gt;&lt;/td&gt;&lt;/tr&gt;&lt;tr&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;-&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;  9m&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;  6min&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 
55min&lt;/td&gt;&lt;td&gt;&amp;nbsp;&lt;/td&gt;&lt;/tr&gt;&lt;tr&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;-&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;  6m&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 14min&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 69min&lt;/td&gt;&lt;td 
style='padding-left: 10px; color: red; float: 
left;'&gt;&lt;b&gt;Sauerstoff&lt;/b&gt;&lt;/td&gt;&lt;/tr&gt;&lt;tr&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;&amp;#10138;&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;  0m&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;  6min&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 
75min&lt;/td&gt;&lt;td&gt;&amp;nbsp;&lt;/td&gt;&lt;/tr&gt;&lt;/tbody&gt;&lt;/table&gt;&lt;br&gt;&lt;div&gt;CNS:
 65%&lt;br&gt;OTU: 112&lt;br&gt;&lt;/div&gt;&lt;div&gt;Dekomodell: VPM-B mit 
Konservatismus +2, effektive GF=75/75&lt;br&gt;Oberflächendruck: 1013mbar 
(0m)&lt;br&gt;&lt;/div&gt;&lt;div&gt;Gasverbrauch (basierend auf AMV 
18|15ℓ/min):&lt;br&gt;854ℓ/77bar von &lt;span style='color: 
red;'&gt;&lt;b&gt;EAN50&lt;/b&gt;&lt;/span&gt; (474ℓ/44bar im berechneten 
Aufstieg)&lt;br&gt;3017ℓ/131bar von &lt;span style='color: 
red;'&gt;&lt;b&gt;(21/35)&lt;/b&gt;&lt;/span&gt; (211ℓ/9bar im berechneten 
Aufstieg)&lt;br&gt;&amp;nbsp;&amp;mdash; &lt;span style='color: 
red;'&gt;Minimum gas&lt;/span&gt; (based on 3.3xSAC/+4min@45m): 
2008ℓ/84bar&lt;br&gt;432ℓ/59bar von &lt;span style='color: 
red;'&gt;&lt;b&gt;Sauerstoff&lt;/b&gt;&lt;/span&gt; (432ℓ/61bar im berechneten 
Aufstieg)&lt;br&gt;&lt;/div&gt;</notes>
  <cylinder size='11.094 l' workpressure='210.0 bar' description='AL80' 
o2='50.0%' start='210.0 bar' end='133.112 bar' />
  <cylinder size='24.0 l' workpressure='200.0 bar' description='D12 232 bar' 
o2='21.0%' he='35.0%' start='200.0 bar' end='69.31 bar' />
  <cylinder size='7.0 l' workpressure='200.0 bar' description='ALU7' 
o2='100.0%' start='200.0 bar' end='141.048 bar' />
  <divecomputer model='planned dive'>
  <depth max='45.0 m' mean='23.717 m' />
  <surface pressure='1.013 bar' />
  <water salinity='1020 g/l' />
  <event time='10:01 min' type='25' value='2293781' name='gaschange' 
cylinder='1' o2='21.0%' he='35.0%' />
  <event time='43:35 min' type='11' value='50' name='gaschange' cylinder='0' 
o2='50.0%' />
  <event time='56:01 min' type='11' value='100' name='gaschange' cylinder='2' 
o2='100.0%' />
  <sample time='0:00 min' depth='0.0 m' pressure='210.0 bar' />
  <sample time='5:00 min' depth='15.0 m' pressure='195.716 bar' />
  <sample time='10:00 min' depth='15.0 m' pressure='175.484 bar' />
  <sample time='10:01 min' depth='15.0 m' />
  <sample time='15:00 min' depth='45.0 m' pressure='184.461 bar' />
  <sample time='40:00 min' depth='45.0 m' pressure='78.159 bar' />
  <sample time='41:54 min' depth='25.998 m' pressure='72.782 bar' />
  <sample time='43:34 min' depth='21.0 m' pressure='69.31 bar' />
  <sample time='43:35 min' depth='21.0 m' pressure='157.6 bar' />
  <sample time='48:34 min' depth='21.0 m' pressure='154.843 bar' />
  <sample time='52:34 min' depth='9.0 m' pressure='141.559 bar' />
  <sample time='55:00 min' depth='9.0 m' pressure='135.429 bar' />
  <sample time='56:00 min' depth='6.0 m' pressure='133.112 bar' />
  <sample time='56:01 min' depth='6.0 m' />
  <sample time='69:00 min' depth='6.0 m' pressure='157.6 bar' />
  <sample time='75:16 min' depth='0.0 m' pressure='141.048 bar' />
  </divecomputer>
</dive>
</dives>
</divelog>

<divelog program='subsurface' version='3'>
<settings>
</settings>
<divesites>
</divesites>
<dives>
<dive number='1' date='2017-09-20' time='10:49:57' duration='75:16 min'>
  <notes>&lt;div&gt;&lt;b&gt;Subsurface (4.6.4.842) Plan&lt;/b&gt; erstellt am 
20.09.17&lt;/b&gt;&lt;br&gt;Runtime: 
75min&lt;br&gt;&lt;/div&gt;&lt;table&gt;&lt;thead&gt;&lt;tr&gt;&lt;th&gt;&lt;/th&gt;&lt;th&gt;Tiefe&lt;/th&gt;&lt;th
 style='padding-left: 10px;'&gt;Dauer&lt;/th&gt;&lt;th style='padding-left: 
10px;'&gt;Runtime&lt;/th&gt;&lt;th style='padding-left: 10px; float: 
left;'&gt;Gas&lt;/th&gt;&lt;/tr&gt;&lt;/thead&gt;&lt;tbody style='float: 
left;'&gt;&lt;tr&gt;&lt;td style='padding-left: 10px; float: 
right;'&gt;&amp;#10136;&lt;/td&gt;&lt;td style='padding-left: 10px; float: 
right;'&gt; 15m&lt;/td&gt;&lt;td style='padding-left: 10px; float: right;'&gt;  
5min&lt;/td&gt;&lt;td style='padding-left: 10px; float: right;'&gt;  
5min&lt;/td&gt;&lt;td style='padding-left: 10px; color: red; float: 
left;'&gt;&lt;b&gt;EAN50&lt;/b&gt;&lt;/td&gt;&lt;/tr&gt;&lt;tr&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;&amp;#10137;&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 15m&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;  5min&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 10min&lt;/td&gt;&lt;td 
style='padding-left: 10px; color: red; float: 
left;'&gt;&lt;b&gt;(21/35)&lt;/b&gt;&lt;/td&gt;&lt;/tr&gt;&lt;tr&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;&amp;#10136;&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 45m&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;  5min&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 
15min&lt;/td&gt;&lt;td&gt;&amp;nbsp;&lt;/td&gt;&lt;/tr&gt;&lt;tr&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;&amp;#10137;&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 45m&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 25min&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 
40min&lt;/td&gt;&lt;td&gt;&amp;nbsp;&lt;/td&gt;&lt;/tr&gt;&lt;tr&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;&amp;#10138;&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 21m&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;  4min&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 
44min&lt;/td&gt;&lt;td&gt;&amp;nbsp;&lt;/td&gt;&lt;/tr&gt;&lt;tr&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;-&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 21m&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;  5min&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 49min&lt;/td&gt;&lt;td 
style='padding-left: 10px; color: red; float: 
left;'&gt;&lt;b&gt;EAN50&lt;/b&gt;&lt;/td&gt;&lt;/tr&gt;&lt;tr&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;-&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;  9m&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;  6min&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 
55min&lt;/td&gt;&lt;td&gt;&amp;nbsp;&lt;/td&gt;&lt;/tr&gt;&lt;tr&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;-&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;  6m&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 14min&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 69min&lt;/td&gt;&lt;td 
style='padding-left: 10px; color: red; float: 
left;'&gt;&lt;b&gt;Sauerstoff&lt;/b&gt;&lt;/td&gt;&lt;/tr&gt;&lt;tr&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;&amp;#10138;&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;  0m&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt;  6min&lt;/td&gt;&lt;td 
style='padding-left: 10px; float: right;'&gt; 
75min&lt;/td&gt;&lt;td&gt;&amp;nbsp;&lt;/td&gt;&lt;/tr&gt;&lt;/tbody&gt;&lt;/table&gt;&lt;br&gt;&lt;div&gt;CNS:
 65%&lt;br&gt;OTU: 112&lt;br&gt;&lt;/div&gt;&lt;div&gt;Dekomodell: VPM-B mit 
Konservatismus +2, effektive GF=75/75&lt;br&gt;Oberflächendruck: 1013mbar 
(0m)&lt;br&gt;&lt;/div&gt;&lt;div&gt;Gasverbrauch (basierend auf AMV 
18|15ℓ/min):&lt;br&gt;854ℓ/77bar von &lt;span style='color: 
red;'&gt;&lt;b&gt;EAN50&lt;/b&gt;&lt;/span&gt; (474ℓ/44bar im berechneten 
Aufstieg)&lt;br&gt;3017ℓ/131bar von &lt;span style='color: 
red;'&gt;&lt;b&gt;(21/35)&lt;/b&gt;&lt;/span&gt; (211ℓ/9bar im berechneten 
Aufstieg)&lt;br&gt;&amp;nbsp;&amp;mdash; &lt;span style='color: 
red;'&gt;Minimum gas&lt;/span&gt; (based on 3.3xSAC/+4min@45m): 
2008ℓ/84bar&lt;br&gt;432ℓ/59bar von &lt;span style='color: 
red;'&gt;&lt;b&gt;Sauerstoff&lt;/b&gt;&lt;/span&gt; (432ℓ/61bar im berechneten 
Aufstieg)&lt;br&gt;&lt;/div&gt;</notes>
  <cylinder size='11.094 l' workpressure='210.0 bar' description='AL80' 
o2='50.0%' start='210.0 bar' end='133.112 bar' />
  <cylinder size='24.0 l' workpressure='200.0 bar' description='D12 232 bar' 
o2='21.0%' he='35.0%' start='200.0 bar' end='69.31 bar' />
  <cylinder size='7.0 l' workpressure='200.0 bar' description='ALU7' 
o2='100.0%' start='200.0 bar' end='141.048 bar' />
  <divecomputer model='planned dive'>
  <depth max='45.0 m' mean='23.717 m' />
  <surface pressure='1.013 bar' />
  <water salinity='1020 g/l' />
  <event time='10:01 min' type='25' value='2293781' name='gaschange' 
cylinder='1' o2='21.0%' he='35.0%' />
  <event time='43:35 min' type='11' value='50' name='gaschange' cylinder='0' 
o2='50.0%' />
  <event time='56:01 min' type='11' value='100' name='gaschange' cylinder='2' 
o2='100.0%' />
  <sample time='0:00 min' depth='0.0 m' pressure='210.0 bar' />
  <sample time='5:00 min' depth='15.0 m' pressure='195.716 bar' />
  <sample time='10:00 min' depth='15.0 m' pressure='175.484 bar' />
  <sample time='10:01 min' depth='15.0 m' />
  <sample time='15:00 min' depth='45.0 m' pressure='184.461 bar' />
  <sample time='40:00 min' depth='45.0 m' pressure='78.159 bar' />
  <sample time='41:54 min' depth='25.998 m' pressure='72.782 bar' />
  <sample time='43:34 min' depth='21.0 m' pressure='69.31 bar' />
  <sample time='43:35 min' depth='21.0 m' />
  <sample time='48:34 min' depth='21.0 m' pressure='154.843 bar' />
  <sample time='52:34 min' depth='9.0 m' pressure='141.559 bar' />
  <sample time='55:00 min' depth='9.0 m' pressure='135.429 bar' />
  <sample time='56:00 min' depth='6.0 m' pressure='133.112 bar' />
  <sample time='56:01 min' depth='6.0 m' />
  <sample time='69:00 min' depth='6.0 m' pressure='157.6 bar' />
  <sample time='75:16 min' depth='0.0 m' pressure='141.048 bar' />
  </divecomputer>
</dive>
</dives>
</divelog>

_______________________________________________
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface