On 8 December 2017 at 17:00, Thiago Macieira <thi...@macieira.org> wrote: > On sexta-feira, 8 de dezembro de 2017 05:49:34 PST Dirk Hohndel wrote: >> > On Dec 8, 2017, at 7:46 AM, Thiago Macieira <thi...@macieira.org> wrote: >> > >> > On Friday, 8 December 2017 03:21:04 PST Dirk Hohndel wrote: >> >> Actually, I just wanted to switch to Qt 5.10 and start testing with that. >> > >> > Please note that 5.10.0 has problems renaming files on Android, due to an >> > unexpected SELinux rule. I advise to wait for 5.10.1. >> >> Thank you for that warning! >> >> I started looking at 5.10.0 for iOS, haven't even looked at Android, yet. >> I will hold off. Is there an ETA for 5.10.1 (since that's a pretty >> catastrophic bug)? > > I don't know if Subsurface uses Qt for renaming files. It doesn't affect > QTemporaryFile, QSaveFile and QSettings, though. > > 5.10.1 should be out just after new years. >
i don't think we have QFile::rename() anywhere. we do use the <stdio.h> (_w)rename() which is wrapped around "subsurface_rename()" and defined in the platform files - linux.c, windows.c, etc. on Android the <stdio.h> rename() is linked against, and possibly called by subsurface_rename() in core/save-xml.c. so this shouldn't be a problem unless the standard library rename() on Android is broken too. lubomir -- _______________________________________________ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
