> On 11. Oct 2020, at 12:53, Robert Helling via subsurface > <subsurface@subsurface-divelog.org > <mailto:subsurface@subsurface-divelog.org>> wrote: > > is it possible that all your builds are with webkit?
Building in a fresh build directory without webkit option I get the error from #ifndef NO_PRINTING #include <QPrintDialog> #include <QBuffer> #include "desktop-widgets/printdialog.h" #endif Somehow, NO_PRINTING seems not to be defined. If I add #define NO_PRINTING ON above, the build succeeds. I must admit, I don’t really understand the relation between environment variables in the build script, variables in cmake and macro definitions in the C source and how one is supposed to influence the other. My suspicion is that in 7f896ee8d5 diff --git a/cmake/Modules/HandleFindGrantlee.cmake b/cmake/Modules/HandleFindGrantlee.cmake deleted file mode 100644 index becffd9a8..000000000 --- a/cmake/Modules/HandleFindGrantlee.cmake +++ /dev/null @@ -1,19 +0,0 @@ -if(NO_PRINTING) - message(STATUS "building without printing support") - add_definitions(-DNO_PRINTING) - set(GRANTLEE_LIBRARIES "") -else() - if(LIBGRANTLEE_FROM_PKGCONFIG) - pkg_config_library(GRANTLEE libgrantlee REQUIRED) we should have this somewhere else. Best Robert
signature.asc
Description: Message signed with OpenPGP
_______________________________________________ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
