That's odd and shouldn't be possible. Are you sure you actually downloaded the 
dive with 5.0.7 and it wasn't downloaded from the dive computer with a previous 
version and then just displayed with 5.0.7?

With 5.0.7 and 5.0.8 on OC you should get "ZH-L16" and "Saturation 77, 
Desaturation 78". And CCR you should get "ZH-L16-GF" and "GF 40/80".

With older versions, and current master, you should get "ZH-L16-GF" and "GF 
40/80".

Anyway, the bug is fixed so future versions should get the right information in 
either case.

/Michael

On Thursday 28 April 2022 22:07:37 CEST Martin Gröger wrote:
> hm...
> 
> interesting, 'cause I dive OC and the extra info says
> "ZHL16" and "GF40/80" as my ostc is set
> (subsurface 5.0.7 /hwos 3.17)
> 
> 
> 
> ________________________________
> From: h...@ruin.nu <h...@ruin.nu> on behalf of Michael Andreen <h...@ruin.nu>
> Sent: Thursday, April 28, 2022 7:19:55 PM
> To: Martin Gröger <martingroe...@hotmail.com>; Subsurface Mailing List 
> <subsurface@subsurface-divelog.org>; JB2Cool <jb2c...@gmail.com>
> Subject: Re: OSTC extra info (deco model and deco model info) not downloading 
> correctly in newer Subsurface releases (5.0.7 and 5.0.8)
> 
> I don't have access to the screenshot, but it shouldn't be related to the 
> OSTC firmware. The core problem was a bad merge between changes to the OSTC 
> parser in Jef's master branch and the Subsurface specific additions in the 
> Subsurface-DS9 branch. In short the dive mode (e.g. OC or CCR) got mixed up 
> with deco model (old ostc buhlman or gradient factors). If Martin is diving 
> CCR then he would get gradient factors in the log, while anyone diving OC 
> would get the old deco model (with hardcoded saturation and desaturation 
> parameters).
> 
> /Michael
> 
> On Thursday 28 April 2022 18:48:14 CEST JB2Cool via subsurface wrote:
> > Martin,
> > What OSTC firmware are you using? I wonder if you'll see this if you
> > upgrade to 3.18 i think that's when i started seeing this,
> >
> > Jason
> >
> > On Thu, 28 Apr 2022 at 17:32, Martin Gröger <martingroe...@hotmail.com>
> > wrote:
> >
> > > Hm…
> > >
> > > I can’t confirm that issue (see screen)
> > > data downloaded subsurface desktop 5.07/OSTC plus
> > > deco model & gf all ok
> > >
> > > Keep on howling
> > >
> > > grey
> > >
> > >
> > >
> > > *Von: *JB2Cool via subsurface <subsurface@subsurface-divelog.org>
> > > *Gesendet: *Montag, 4. April 2022 10:22
> > > *An: *Subsurface Mailing List <subsurface@subsurface-divelog.org>
> > > *Betreff: *Re: OSTC extra info (deco model and deco model info) not
> > > downloading correctly in newer Subsurface releases (5.0.7 and 5.0.8)
> > >
> > >
> > >
> > > Someone replied over at the Heinrichs Weikamp forum (
> > > https://forum.heinrichsweikamp.com/viewtopic.php?p=23678#p23678) saying
> > > that it looks like libdivecomputer is using the wrong memory addresses for
> > > this information (this was correct previously). A pull request (
> > > https://github.com/subsurface/libdc/pull/32) has been generated that
> > > hopefully reverts this.
> > >
> > >
> > >
> > > I'll try to build locally with those adjustments and see if this
> > > straightens things out for me.
> > >
> > >
> > >
> > > Jason
> > >
> > >
> > >
> > > On Sun, 3 Apr 2022 at 20:33, JB2Cool <jb2c...@gmail.com> wrote:
> > >
> > > Good evening,
> > >
> > > I’ve downloaded some dives today and realised the 'extra info' on my OSTC
> > > is not downloading correctly. I originally reported this to Heinrichs
> > > Weikamp here (https://forum.heinrichsweikamp.com/viewtopic.php?t=22302)
> > > as these were the first dives I’ve done on this new OSTC firmware but
> > > subsequent troubleshooting makes this look like the issue is at the
> > > Subsurface or libdivecomputer end.
> > >
> > >
> > >
> > > I’ve downloaded some older AppImages and this works fine on 5.0.5 and
> > > 5.0.6 but shows the undesirable behaviour on 5.0.7 and 5.0.8.
> > >
> > >
> > >
> > > Extra info on dives with older versions of Subsurface look like:
> > >
> > >
> > >
> > > FW Version 3.17
> > > Deco model ZH-L16-GF
> > > Deco model info GF 30/85
> > >
> > > Now with the newest 2 versions of Subsurface extra info looks like:
> > >
> > > FW Version 3.18
> > > Deco model ZH-L16
> > > Deco model info Saturation 77, Desaturation 78
> > >
> > > It’s still doing this for dives that have downloaded fine in the past
> > > where I know the dive was completed with the gradient factor model. This
> > > only seems to affect newly downloaded dives, if something was downloaded
> > > correctly in the past on a ‘good’ version then it will still display
> > > correctly on a ‘bad’ version but if you were to download the dive again on
> > > a ‘bad’ version then the issue would present itself (I may not be making
> > > myself clear here).
> > >
> > >
> > >
> > > I've hopefully captured the relevant logs/dumps that will help with
> > > troubleshooting.
> > >
> > >
> > >
> > > If I can provide screenshots or more information I'm of course happy to do
> > > that.
> > >
> > >
> > >
> > > Regards
> > >
> > > Jason
> > >
> > >
> > >
> 
> 
> 
> 




_______________________________________________
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Reply via email to