On Wed, Sep 9, 2009 at 3:26 PM, Simon Schampijer<si...@schampijer.de> wrote: > On 09/07/2009 11:14 PM, Simon Schampijer wrote: >> On 09/07/2009 10:23 PM, Sayamindu Dasgupta wrote: >>> On Mon, Sep 7, 2009 at 11:54 PM, Sayamindu Dasgupta<sayami...@gmail.com> >>> wrote: >>>> Hello, >>>> The attached diff makes ImageViewer work with the newer toolbar >>>> system. I have tested it in a sugar-jhbuild environment, and have >>>> found no regressions. >>> Based on Simon's inputs on IRC, I have updated the patch. New one is >>> attached. >>> >>> Thanks, >>> Sayamindu >> >> Hmm, I think we said in a design meeting that all the buttons should be >> left aligned (expect the stop button). So maybe you want to put the >> fullscreen button the the left as well. >> >> Please, mind the 80 colums and the two '_' for callbacks ;D >> >> I tested all the buttons as working fine! >> >> Thanks, >> Simon > > Did you handle those comments? >
two __ has been done. I'll do the 80 columns thingy and a general pylint check with the next release. Thanks, Sayamindu -- Sayamindu Dasgupta [http://sayamindu.randomink.org/ramblings] _______________________________________________ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
