On Tue, Aug 17, 2010 at 20:52, C. Scott Ananian <csc...@laptop.org> wrote: > On Wed, Aug 11, 2010 at 6:22 PM, Tomeu Vizoso <to...@sugarlabs.org> wrote: >> Because of this specific commit, file transfers have been broken since >> early this year and it's obvious that this code wasn't tested at all: >> >> http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/11828796 >> >> Given the current poor state of our testing efforts, committers should >> be extra careful about this. > > Out of curiosity: what was the failure? It's not obvious to me, in > reading the patch; I can see how problems wouldn't be caught by a > reviewer. If it's a Python syntax problem, you might consider using a > tool to automatically report (ie, via email or directly into a > bugtracker) uncaught python exceptions. That would give you better > coverage at least of brain-dead "it will crash as soon as you try to > use it" problems.
These are the fixes, I think pylint would have detected them: http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/177cbfab http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/fbd1f1e7 Regards, Tomeu > --scott > > -- > ( http://cscott.net/ ) > _______________________________________________ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
