On Sun, Oct 17, 2010 at 12:58:27AM +0530, Ishan Bansal wrote: > Hi Aleksey > > I had submitted the patch for the http://bugs.sugarlabs.org/ticket/2318 > > You can check the patch at > http://www.mail-archive.com/sugar-devel@lists.sugarlabs.org/msg16721.html > > Wish if you could review it and provide me feedback on any improvement > required.
You need to check your patch (only your patch, the rest of code does not conform all checks) w/ pylint/pep8 (eg using sugar-lint[1]). > + label = 'Journal' string needs to be kept gettextized ie _('Journal') [1] http://wiki.sugarlabs.org/go/Activity_Team/Sugar_Lint -- Aleksey _______________________________________________ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel