On Thu, Oct 21, 2010 at 10:45:12AM -0400, Bernie Innocenti wrote: > On Thu, 2010-10-21 at 12:57 +1100, James Cameron wrote: > > On Wed, Oct 20, 2010 at 10:16:52PM -0200, Bernie Innocenti wrote: > > > On Wed, 2010-10-20 at 21:36 +0530, Anurag Chowdhury wrote: > > > > I have uploaded the icon file at https://dev.laptop.org/ticket/4170 > > > > needed for the patch. > > > > > > It would be better if you could keep the icons with the patches. > > > > I disagree, sometimes they significantly hinder code review. It is up > > to the author of the patch to figure out how to present it best for > > review. Sometimes this might be as a separate patch. > > But then what would the maintainer have to do to commit the complete > patch? First "git am", then "git add" the icon, then "git commit > --amend". In order to backport the patch to something like Dextrose, I'd > have to repeat the same job.
I don't see how that workflow is a consequence of my suggestion, since "git add" would not be required. Perhaps you thought I was suggesting the icon be attached to the mail. Not my intention. I was thinking of a patch series, as seen here already from others, and seen frequently in other projects. > To keep patches readable _and_ easy to apply without too much manual > labor, perhaps the submitter could split off the icon to a separate > patch? Yes, that is my suggestion. > You're right, one would have to apply the patch so they can open the > icon in a viewer. Providing a separate link to the icon would save > time, I agree with you. Then once that is common behaviour, we can whinge about the icon in context, and ask for screenshots. ;-) -- James Cameron http://quozl.linux.org.au/ _______________________________________________ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel