On 12/06/2010 11:28 AM, Simon Schampijer wrote:
Hi Gonzalo,
so the issue is the following:
We do only set the color when the palette is popped down. This does
break the following case:
- select text you want to change the color of
- open the color chooser and change the color
- do click anywhere in the canvas (not the selected text) and don't wait
for the palette to popdown
---> The text is not selected anymore when the palette pops down, hence
the new color will not be applied.
I think the reason why Benjamin decided to set the color when the
palette is closed is that when you would emit a color change on each
change in the selector using the sliders would end up in a lot of
signaling. That is why color selectors either have a fixed set of colors
the user can select from or the custom selector with sliders is a dialog
(ok, cancel) and therefore it is known when the user has made his decision.
How to move forward now with this? We could make at list the selector
field emit the change directly. For the "slidered color selector", I am
not sure. All the ideas I had did have possible races. Maybe we can live
with the overhead of signaling and just make send it updates? Other ideas?
A good example of a case where it makes sense to have the sliders
emitting the change directly can be seen here in the modified Paint
activity:
http://www.youtube.com/watch?v=KQFLNWNnN0Q&feature=player_embedded
Regards,
Simon
_______________________________________________
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
