On 02/04/2011 08:17 AM, Gonzalo Odiard wrote:
On Thu, Feb 3, 2011 at 4:26 PM, Simon Schampijer<[email protected]>wrote:
Hi Gonzalo,
looks good to me. Please push to the master branch.
I think you added to Gonzalo Delgado, not me.
I am godiard in git.
Sorry, done now.
From the icons under icons/scalable/actions the logout icon does not honour
the stroke and fill colour - I would take a patch for that one, too :)
@Gary, do you think it is safe to include in all those icons the stroke
and fill colour? Do you think there was a specific reason to not do so
for those icons?
All this icons don't have the entities defined:
cell-format.svg
cell-height.svg
cell-size.svg
cell-width.svg
column-insert.svg
column-remove.svg
edit-redo.svg
edit-undo.svg
format-columns-double.svg
format-columns-single.svg
format-columns-triple.svg
format-justify-center.svg
format-justify-fill.svg
format-justify-left.svg
format-justify-right.svg
format-text-bold.svg
format-text-italic.svg
format-text-leading.svg
format-text-size.svg
format-text-underline.svg
go-next-paired.svg
go-previous-paired.svg
insert-image.svg
insert-table.svg
invite.svg
row-insert.svg
row-remove.svg
system-logout.svg
toolbar-colors.svg
tray-hide.svg
tray-show.svg
view-refresh.svg
zoom-best-fit.svg
zoom-in.svg
zoom-out.svg
To get the list i did:
[gonzalo@aronax actions]$ ls *.svg | sort> /tmp/all_icons.txt
[gonzalo@aronax actions]$ grep "ENTITY stroke_color" *.svg | awk -F":"
'{printf("%s\n", $1)}' | sort> /tmp/icons_with_entities.txt
[gonzalo@aronax actions]$ diff -u /tmp/icons_with_entities.txt
/tmp/all_icons.txt | grep "+" | grep -v "@"
I have created a ticket http://dev.laptop.org/ticket/10663 to follow this.
Gonzalo
OT: checking the existing tickets I found http://dev.laptop.org/ticket/8612,
I think must be closed
Yes, done so - thanks!
Regards,
Simon
_______________________________________________
Sugar-devel mailing list
[email protected]
http://lists.sugarlabs.org/listinfo/sugar-devel
